zstd @1.5.6: does not respect macos setting on build

[lukaso (Lukas Oberhuber)]

Even after setting this, the build still leaves zstd build for the MacOS version it is running on:

  echo 'macosx_deployment_target 10.13' | tee -a ${PREFIX}/etc/macports/macports.conf
  echo 'macosx_sdk_version 10.13' | tee -a ${PREFIX}/etc/macports/macports.conf

From otool -l

Load command 10
      cmd LC_BUILD_VERSION
  cmdsize 32
 platform 1
    minos 13.0
      sdk 13.3
   ntools 1
     tool 3
  version 857.1

[lukaso (Lukas Oberhuber)]

It looks like this bug was introduced upstream in v1.5.6

[ryandesign (Ryan Carsten Schmidt)]

Do you check each library manually or is there an easy way to audit all of the libraries that your program depends on to find the ones that have this problem?

[lukaso (Lukas Oberhuber)]

I’ve written a program to check it (or should I say, chat-gpt wrote me a program to check it.) Happy to upload if it would be helpful.

But in this instance it came via a bug report as I’d not incorporated the script into the CI system.

[lukaso (Lukas Oberhuber)]

Similar to #69947

[ryandesign (Ryan Carsten Schmidt)]

I was just curious for my own purposes whether you had to parse the otool -l output or if there was a better API for getting just the interesting values, and how you were collecting the list of libraries that you needed to check.

[lukaso (Lukas Oberhuber)]

@ryandesign here's the script. Sorry, should have posted sooner! ​https://gitlab.gnome.org/Infrastructure/gimp-macos-build/-/blob/master/scripts/validate_min_os.py?ref_type=heads

[lukaso (Lukas Oberhuber)]

whether you had to parse the otool -l output or if there was a better API

I parse otool -l to answer your actual question.

how you were collecting the list of libraries that you needed to check

I use a bunch of packaging scripts, which, to make a long story short, follow all the library dependencies from GIMP on down and copy them into the relevant directories, while fixing up @rpaths and doing a bunch of other admin. I then run this script on all libraries that have been copied in and which will eventually be packaged into GIMP.app.

[lukaso (Lukas Oberhuber)]

here's the upstream issue (should have posted as well): ​https://github.com/facebook/zstd/issues/4038

[lukaso (Lukas Oberhuber)]

Fix submitted and approved (but not merged): ​https://github.com/facebook/zstd/pull/4191

[lukaso (Lukas Oberhuber)]

From zstd. Closed #4038(​https://github.com/facebook/zstd/issues/4038) as completed via [d0fe334](​https://github.com/facebook/zstd/commit/d0fe334c8552edb764b853854037697c6710fa64).

I think we'll have to wait on 1.5.8 however to get the fix.

[lukaso (Lukas Oberhuber)]

Was released in 1.5.7: ​https://released.blabberate.com/r/facebook/zstd/c/d0fe334

[lukaso (Lukas Oberhuber)]

Ticket should be closed.