Opened 18 years ago

Closed 17 years ago

#7316 closed defect (fixed)

py-libxml2 does not install libxslt module

Reported by: sfiera@… Owned by: michaelm@…
Priority: Normal Milestone:
Component: ports Version: 1.2
Keywords: Cc: vincent-opdarw@…, markd@…
Port:

Description

The current version of the py-libxml2 module works by extracting specific portions of the libxml2 package. This doesn't include the libxslt module, though. There's a python-specific package available, which will be used by this portfile:


# $Id: Portfile,v 1.3 2005/04/19 18:15:09 jberry Exp $

PortSystem 1.0 PortGroup python24 1.0

name py-libxml2 version 2.6.21 categories python textproc platforms darwin maintainers michaelm@… description Python bindings for libxml2 and libxslt long_description ${description}

homepage http://xmlsoft.org/ master_sites ftp://xmlsoft.org/python/ distname libxml2-python-${version} checksums md5 229dd2b3d110a77defeeaa73af83f7f3

dist_subdir libxml2

depends_lib-append port:libxml2 \

port:zlib

build.env CFLAGS="-I${prefix}/include/libxml2" \

LDFLAGS=-L${prefix}/lib

post-destroot {

xinstall -m 644 -W ${worksrcpath} README TODO \

${destroot}${prefix}/share/doc/${name}

}

Change History (7)

comment:1 Changed 18 years ago by blb@…

Owner: changed from darwinports-bugs@… to michaelm@…

Assigning to maintainer.

comment:2 Changed 18 years ago by markd@…

Cc: markd@… added

We need to do what the FreeBSD folks did. Remove python bindings from libxml2. The patches to do this could be directly cribbed from theirs. Then the same thing needs to be done for port libxslt AND then a new py-libxslt created since one does not exist in DP. This is just like FreeBSD did so you have:

libxml2 libxslt py-libxml2 py-libxslt

and no conflicts between them. This would take care of this bug and 5255 and 5355 as well. It would be a quick job for a motivated person. Anyone?

comment:3 Changed 18 years ago by markd@…

(In reply to comment #2)

so you'd have:

libxml2 libxslt py-libxml2 py-libxslt

Then again, is there a good reason that libxml2 and py-libxml2 cannot be combined into one? I'm just wondering if it is really necessary to have 4 ports instead of a libxml2 and libxslt that also install their python support by default, or maybe as a +python variant for each. I don't know why the FreeBSD folks chose to use a separate port so I guess all options should be considered.

comment:4 Changed 18 years ago by vincent-opdarw@…

Cc: vincent-opdarw@… added

(In reply to comment #3)

Then again, is there a good reason that libxml2 and py-libxml2 cannot be combined into one? I'm just wondering if it is really necessary to have 4 ports instead of a libxml2 and libxslt that also install their python support by default, or maybe as a +python variant for each.

I think that a variant would currently be a bad idea since AFAIK, one can't depend on a variant and some installations may fail due to that (e.g. if some user needs the variant but hasn't chosen it).

I don't know why the FreeBSD folks chose to use a separate port so I guess all options should be considered.

Perhaps because it would take more memory and would need more dependencies. For instance, "port info py-libxml2" says that it depends on python24. I certainly don't want to be forced to install python24[*] just because I want libxml2.

[*] meaning more maintainance, more compilation time, more disk space and more risk of install failure for someone who doesn't need python.

comment:5 Changed 18 years ago by markd@…

(In reply to comment #4)

I think that a variant would currently be a bad idea since AFAIK, one can't depend on a variant and some installations may fail due to that (e.g. if some user needs the variant but hasn't chosen it).

it would take more memory and would need more dependencies. For instance, "port info py-libxml2" says that it depends on python24. I certainly don't want to be forced to install python24[*] just because I want libxml2.

Yeah you're right. I was up late last night and guess I wasn't thinking so well this morning. The reasons seem perfectly clear now. Now if only someone who's interested will take an hour or so and just mimic the FreeBSD patches for libxml2 and libxslt and then make a py-libxslt port. I 've done enough bug squashing for now.

comment:6 Changed 18 years ago by sfiera@…

As far as I can tell, libxslt does not itself have the ability to build the python bindings - there is no setup.py included with it. The current py-libxml2 portfile already does what you suggested, though, and it would probably be possible to tweak the above portfile such that it would depend on py-libxml2 and only install the libxslt bindings.

comment:7 Changed 17 years ago by sfiera@…

Resolution: fixed
Status: newclosed

Closed by r25246

Note: See TracTickets for help on using tickets.