port lint should check non-selected variants and platforms

[ryandesign (Ryan Carsten Schmidt)]

port lint checks patchfile names (see #12958) but only in variants or platforms which are selected. For example, if a portfile includes

platform darwin 6 {
	patchfiles foo
}

and one is not running Mac OS X 10.2, then no warning is issued for the patchfile foo, though one should be. Or if a portfile includes

variant abc description abc {
	patchfiles bar
}

and one does not run sudo port lint +abc (and +abc is not a default variant), then no warning issued for the patchfile bar, though one should be.

[afb@…]

Proabably should be made more generic, so that it runs all checks on inactive variants ?

[ryandesign (Ryan Carsten Schmidt)]

Of course. I mean, one phase of lint simply does a line-by-line check of the portfile, so that phase already checks inactive variants. But whatever the second phase does (including checking patchfiles as reported in this ticket and checking port dependencies as reported in #14380) should check inactive variants as well, somehow.

[tobypeterson]

Milestone MacPorts base bugs deleted