Opened 15 years ago

Closed 15 years ago

#21330 closed update (fixed)

openmotif: update to 2.3.2 and add missing uintptr_t casts

Reported by: howarth@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.8.0
Keywords: motif Cc:
Port: openmotif

Description

The openmotif package should be updated to the latest 2.3.2 release. There are also a number of warning in openmotif when compiled as x86_64 of the form "cast to pointer from integer of different size" which I fixed in the fink openmotif4 package with the patch submitted to upstream...

http://bugs.motifzone.net/show_bug.cgi?id=1497

...by casting with uintptr_t where appropriate to avoid sign extension as described in the original gcc patch...

http://gcc.gnu.org/ml/gcc-patches/2005-12/msg00942.html

Attachments (2)

patch-uintptr_t-cast.diff (17.1 KB) - added by howarth@… 15 years ago.
patch to add casts with uintptr_t to eliminate "cast to pointer from integer of different size" warnings
Portfile.diff (1.8 KB) - added by howarth@… 15 years ago.
diff for Portfile changes to update to 2.3.2, apply uintptr_t patch and explicitly set path for libjpeg and libpng

Download all attachments as: .zip

Change History (9)

Changed 15 years ago by howarth@…

Attachment: patch-uintptr_t-cast.diff added

patch to add casts with uintptr_t to eliminate "cast to pointer from integer of different size" warnings

Changed 15 years ago by howarth@…

Attachment: Portfile.diff added

diff for Portfile changes to update to 2.3.2, apply uintptr_t patch and explicitly set path for libjpeg and libpng

comment:1 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Milestone: MacPorts 1.8.1

comment:2 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: update openmotif to 2.3.2 and add missing uintptr_t castsopenmotif: update to 2.3.2 and add missing uintptr_t casts

comment:3 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

I am curious why you added the --with-lib{jpeg,png}-{includes,lib} configure.args since on my system openmotif has already been able to find the MacPorts versions of those libraries without those arguments.

comment:4 Changed 15 years ago by howarth@…

I added the --with-lib{jpeg,png}-{includes,lib} in the fink openmotif3/4 packages just to be absolutely certain that the build never hit the system headers in /usr/include. It would build but I wanted to avoid mismatched headers and libraries.

comment:5 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

In that case, we'll want to add --with-{freetype,fontconfig}-config as well.

Note also that I'll change --with-x-{include,lib} to what the configure script says it supports: --with-x-{includes,libraries}. Not sure if that recently changed or if we've been wrong about that all along.

comment:6 in reply to:  5 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to ryandesign@…:

In that case, we'll want to add --with-{freetype,fontconfig}-config as well.

Er, fontconfig-config was removed from fontconfig in 2003.

comment:7 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

I'm just going to commit the update without those new --with-* flags. MacPorts already ensures via CPPFLAGS (-I), LDFLAGS (-L), CPATH and LIBRARY_PATH that MacPorts libraries get used in preference to system libraries if present, and the dependency declarations ensure that they are present. r57549.

Note: See TracTickets for help on using tickets.