Opened 15 years ago

Closed 14 years ago

#22254 closed defect (fixed)

coq_makefile generates Makefile with ''install -D'' lines

Reported by: kiyoshi.coquser@… Owned by: roederja
Priority: Normal Milestone:
Component: ports Version: 1.8.1
Keywords: haspatch Cc: roederja, reilles@…
Port: coq

Description

The Makefile generated by coq_makefile has lines like follows: 

install:
        mkdir -p $(COQLIB)/user-contrib
        (for i in $(VOFILES0); do \
         install -D $$i $(COQLIB)/user-contrib/$(INSTALLDEFAULTROOT)/$$i; \
         done)
        (for i in $(CMOFILES0); do \
         install -D $$i $(COQLIB)/user-contrib/$(INSTALLDEFAULTROOT)/$$i; \
         done)
        (for i in $(CMIFILES0); do \
         install -D $$i $(COQLIB)/user-contrib/$(INSTALLDEFAULTROOT)/$$i; \
         done)
        (for i in $(CMXSFILES0); do \
         install -D $$i $(COQLIB)/user-contrib/$(INSTALLDEFAULTROOT)/$$i; \
         done)

The install command on the Mac OS X (and *BSD) has no -D option, so make install fails.

A patch attached to this report will fix this issue.

I also reported this issue to Coq bugs (not yet confirmed). ​http://www.lix.polytechnique.fr/coq/bugs/show_bug.cgi?id=2153

Attachments (2)

Portfile.diff​ (735 bytes) - added by kiyoshi.coquser@… 14 years ago.
patch-tools-coq_makefile.ml4.diff​ (1.5 KB) - added by kiyoshi.coquser@… 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 15 years ago by jmroot (Joshua Root)

Keywords: haspatch added
Owner: changed from macports-tickets@… to reilles@…

comment:2 Changed 14 years ago by roederja

Cc: jann@… reilles@… added
Owner: changed from reilles@… to jann@…
Status: new → assigned

The maintainer doesn't seem to respond. If you provide a patch for the portfile itself, I will commit this fix.

Changed 14 years ago by kiyoshi.coquser@…

Attachment: Portfile.diff​ added

Changed 14 years ago by kiyoshi.coquser@…

Attachment: patch-tools-coq_makefile.ml4.diff​ added

comment:3 Changed 14 years ago by kiyoshi.coquser@…

Please use Portfile.diff and patch-tool-coq_makefile.ml4.diff .

comment:4 Changed 14 years ago by roederja

Resolution: → fixed
Status: assigned → closed

Committed in r62316. Thanks.

Note: See TracTickets for help on using tickets.