Opened 19 years ago

Closed 19 years ago

Last modified 8 years ago

#2703 closed defect (fixed)

PATCH: make port accept variants with t's in variants.conf

Reported by: danchr@… Owned by: rshaw@…
Priority: Normal Milestone:
Component: base Version: 1.0
Keywords: Cc:
Port:

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Without the small patch below, having +gtk set in variants.conf will result in the 'g' variant being set, and port complaining about 'k' being invalid variant syntax.

I don't know Tcl, so I have no idea what I'm doing, but it seems like it works :)

Index: base/src/darwinports1.0/darwinports.tcl
===================================================================
RCS file:
/Volumes/src/cvs/od/proj/darwinports/base/src/darwinports1.0/darwinports.tcl,v
retrieving revision 1.155
diff -a -u -u -r1.155 darwinports.tcl
--- base/src/darwinports1.0/darwinports.tcl     13 Feb 2005 03:07:20 -0000     1.155
+++ base/src/darwinports1.0/darwinports.tcl     18 Feb 2005 22:03:17 -0000
@@ -146,7 +146,7 @@
                        while {[gets $fd line] >= 0} {
                                set line [string trimright $line]
                                if {![regexp {^[\ \t]*#.*$|^$} $line]} {
-                                       foreach arg [split $line { \t}] {
+                                       foreach arg [split $line "{ \t}"] {
                                                if {[regexp {^([-+])([-A-Za-z0-9_+\.]+)$} $arg match sign opt] == 1} {
                                                        if {![info exists variations($opt)]} {
                                                                set variations($opt) $sign

Change History (4)

comment:1 Changed 19 years ago by rshaw@…

Owner: changed from darwinports-bugs@… to rshaw@…

Oops, yes that's a mistake in my pattern split. I'll fix this. -rshaw

comment:2 Changed 19 years ago by rshaw@…

Status: newassigned

comment:3 Changed 19 years ago by rshaw@…

Resolution: fixed
Status: assignedclosed

Fix committed. Thanks! -rshaw

comment:4 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Note: See TracTickets for help on using tickets.