Opened 9 years ago

Closed 8 years ago

#29169 closed submission (fixed)

New port: MariaDB 5.2

Reported by: jogwtr@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: NicosPavlov, ryandesign (Ryan Schmidt), pixilla (Bradley Giesbrecht)
Port:

Description

New Portfile and patch for MariaDB 5.2

A database server that offers drop-in replacement functionality for MySQL

Attachments (2)

Portfile (4.8 KB) - added by jogwtr@… 9 years ago.
patch-Makefile.in.diff (362 bytes) - added by jogwtr@… 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by jogwtr@…

Attachment: Portfile added

Changed 9 years ago by jogwtr@…

Attachment: patch-Makefile.in.diff added

comment:1 Changed 8 years ago by NicosPavlov

Cc: nicos@… added

Cc Me!

comment:2 Changed 8 years ago by NicosPavlov

I did take a look at the port, and some points did not seem clear to me:

  • As mariadb is not an existing port yet, why name it mariadb52 and not mariadb ?
  • It seems to me that the set branch line is not used and could be suppressed.
  • I think parallel_build is usually set at yes by default, so that use_parallel_build yes line does not bring anything.
  • Shouldn't the first line of master sites

http://mirrors.supportex.net/mariadb/mariadb-5.2.5/kvm-tarbake-jaunty-x86/ be
http://mirrors.supportex.net/mariadb/${distname}/kvm-tarbake-jaunty-x86/ ?

  • It is considered that md5 hash only is not sufficient. md5, sha1 and rmd160 are default usually.
  • As some time passed, I would suggest to update the port directly to last stable version (5.2.9)

Some of these remarks also apply to mariadb52-server port submission (ticket #29170).

I could then add the port, along with with the server port (ticket #29170). It will also be necessary upon addition to request the addition of a conflict to mariadb with mysql* ports.

comment:3 Changed 8 years ago by NicosPavlov

Cc: ryandesign@… added

cc to ryandesign for the conflict of this port addition with mysql4, mysql5 and mysql5-devel.

comment:4 Changed 8 years ago by pixilla (Bradley Giesbrecht)

Cc: pixilla@… added

Cc Me!

comment:5 Changed 8 years ago by ryandesign (Ryan Schmidt)

Feel free to add the conflicts to the MySQL ports.

comment:6 Changed 8 years ago by pixilla (Bradley Giesbrecht)

While we are at it, how about conflicting and committing the percona submissions as well? #29499 #29500

comment:7 Changed 8 years ago by NicosPavlov

Resolution: fixed
Status: newclosed

Port added in r85113, conflicts added in mysql4, mysql5 and mysql5-devel added respectively in r85115, r85116 and r85117.

I will try to take a look also on percona.

Note: See TracTickets for help on using tickets.