Opened 8 years ago

Closed 3 years ago

#29303 closed defect (fixed)

gant fixes: noarch, remove unnecessary lines, use notes

Reported by: ryandesign (Ryan Schmidt) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: gant

Description

gant doesn't install any architecture-specific files, so should say supported_archs noarch and the revision should be increased.

Further changes you could consider making to gant include removing the distname, worksrcdir and use_bzip2 no lines (those are the defaults); switching from using ui_msg in a post-activate block to using notes; and removing the workTarget variable and the one place it's used, unless it serves some purpose I'm not seeing.

Attachments (2)

gant.diff (1.8 KB) - added by ryandesign (Ryan Schmidt) 8 years ago.
proposed patch
gant.2.diff (1.4 KB) - added by ryandesign (Ryan Schmidt) 8 years ago.
new proposed patch

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: gant.diff added

proposed patch

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

Summary: gant is noarchgant fixes: noarch, remove unnecessary lines, use notes

Not in the attached patch, but you should also remove extract.post_args | gnutar -x from the platform darwin section: it does nothing (MacPorts overwrites extract.post_args when the extract phase begins) and isn't correct (this distfile is a zip file, not a tar file).

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: gant.2.diff added

new proposed patch

comment:2 Changed 8 years ago by ryandesign (Ryan Schmidt)

You added "supported_archs noarch" in r78331; I've attached a revised patch with the remaining changes.

comment:3 Changed 5 years ago by mf2k (Frank Schima)

Owner: changed from breskeby@… to ryandesign@…

breskeby has retired. See #44732.

@ryan: Please commit your changes.

comment:4 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:5 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

I went ahead and commited your patch as well as change to github since the old homepage is no longer valid.

r144182

There's a newer version out.

Note: See TracTickets for help on using tickets.