Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#30647 closed defect (fixed)

rpm52: buggy perl5_* and python* variants

Reported by: blair (Blair Zajac) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.0.1
Keywords: Cc: n3npq@… afb@…
Port: rpm52

Description

The port has these for build dependencies:

depends_build           port:expat port:neon \
                        port:python25 port:perl5.8 \
                        port:readline port:beecrypt \
                        port:libiconv port:gettext

But the perl and python variants modify the library dependencies:

variant perl5_12 description { use perl 5.12 instead of perl 5.8 } {
        depends_lib-delete      port:perl5.8
        depends_lib-append      port:perl5.12
...

I think the variants should all have depends_lib replaced with depends_build.

Let me know and I can commit this change.

I saw this because I had only perl 5.12 on my system and even with the variant, it was building perl 5.8.

Blair

Change History (8)

comment:1 Changed 8 years ago by blair (Blair Zajac)

While I'm looking at this port, rpm's configure will pick up additional runtime dependencies that should be added to the port:

checking for curl... /opt/local/bin/curl
checking for gpg... /opt/local/bin/gpg
checking for hg... /opt/local/bin/hg
checking for install-info... /opt/local/bin/install-info
checking for lzma... /opt/local/bin/lzma
checking for svn... /opt/local/bin/svn
checking for wget... /opt/local/bin/wget
checking for xar... /opt/local/bin/xar
checking for xz... /opt/local/bin/xz
checking for doxygen... /opt/local/bin/doxygen

If removing one of these ports breaks the rpm52 port, then these ports should be specified as dependencies.

There's quite a few of them, so there's two ways to handle this: have rpm52 depend upon them all or tell configure not to use it and possibly add a variant.

comment:2 Changed 8 years ago by afb@…

Resolution: fixed
Status: newclosed

Fixed, r82101.

comment:3 in reply to:  1 Changed 8 years ago by afb@…

Replying to blair@…:

While I'm looking at this port, rpm's configure will pick up additional runtime dependencies that should be added to the port:

Those paths don't matter.

If you start deleting random ports later, you can always edit the rpm macros to match.

comment:4 Changed 8 years ago by afb@…

Actually the _real_ problem here is that there are too many Perl and Python ports :-)

comment:5 Changed 8 years ago by blair (Blair Zajac)

Thanks for the fix. Because the dependencies have changed, the port needs its revisions bumped.

comment:6 Changed 8 years ago by afb@…

Well, technically the dependencies only changed if you used the nonstandard variants

comment:7 Changed 8 years ago by blair (Blair Zajac)

Yes, but we want to make sure all users of the port are set up properly.

Do you have a concern about bumping the revision?

comment:8 Changed 8 years ago by afb@…

I think it's useless to force a rebuild, but increased revision (r82142).

Note: See TracTickets for help on using tickets.