rose @0.9.5a

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some comments:

• Your email address should be obfuscated in the maintainers line: llnl.gov:too1.
• The license should be just "BSD".
• Please fetch from an official distfile. If none is available, fetch from the specific repository revision or branch that represents version 0.9.5a. Fetching from HEAD is not predictable.
• When fetch.type is "git", MacPorts adds git-core as a fetch dependency for you; you don't need to add it manually.
• The dependency on graphviz should be written so that graphviz-devel could satisfy it; see other ports that depend on graphviz for examples of how this is done, or #14540.
• I notice the build dependency on wget... Does this software really use wget to fetch things during its build? Ports should not be fetching things during the build phase; they should fetch all necessary files during the fetch phase, if possible.
• "gcc" is not a valid value for configure.compiler; you seem to want configure.compiler macports-gcc-4.4. Then, where you hardcode ${prefix}/bin/gfortran-mp-4.4, you can replace that with ${configure.fc}. And you can add compiler variants to give users a choice. See PortfileRecipes.
• You probably shouldn't set build.jobs to 0, thereby overriding the user's choice of number of build jobs.
• Note that system now has a -W argument that you can use instead of manually cd'ing into a directory: system -W ${worksrcpath} "./build"

[too1@…]

Thanks for the feedback. I've attached a revised Portfile:

• ROSE has been stuck at v0.9.5a for several years. The master branch would be the best option for our users until we start versioning properly (something we plan on doing soon). Maybe it would be better to have this port be rose-devel?
• ROSE must be compiled with the system default compiler (GCC 4.2.1); so only gfortran-mp-4.4 is needed. Yes, it's a bit quirky to get ROSE installed (a big reason for the MacPort, to help our users install ROSE more easily).

[too1@…]

Cc Me!

[neverpanic (Clemens Lang)]

You don't need to Cc yourself.

[drkp (Dan Ports)]

Replying to too1@…:

Thanks for the feedback. I've attached a revised Portfile:

• ROSE has been stuck at v0.9.5a for several years. The master branch would be the best option for our users until we start versioning properly (something we plan on doing soon). Maybe it would be better to have this port be rose-devel?

Whether it's named -devel or not, we really need the port to install a fixed version of the software rather than checking out HEAD from git -- we need reproducible builds so that MacPorts knows what version a user has installed, and so that we can (possibly) distribute binaries. The usual way to do this would be to use a date or something as the version, and set git.branch to the corresponding commit hash (see libusb-devel for an example).

Other than that, the portfile basically looks reasonable to me...

[neverpanic (Clemens Lang)]

I wanted to commit the Portfile with the following changes:

• Added standard modeline
• Used the github portgroup and github.setup instead of specifying the fetch form github manually
• path:-style dependencies don't need ${prefix}
• Changed github username to rose-compiler, since this apparently is the new home of rose
• Added checksums, since the github portgroup downloads a tar.gz
• Changed default compiler to gcc45, since that currently is our favorite gcc compiler

However, the build failed with:

checking for ROSE Git version information in '/opt/local/var/macports/build/_opt_dports_lang_rose/rose/work/rose-af169e174891539228704cb1befc8fdda4be94c7'... configure: error: in `/opt/local/var/macports/build/_opt_dports_lang_rose/rose/work/rose-af169e174891539228704cb1befc8fdda4be94c7/buildTree':
configure: error: /opt/local/var/macports/build/_opt_dports_lang_rose/rose/work/rose-af169e174891539228704cb1befc8fdda4be94c7/VERSION file does not exist
See `config.log' for more details

I'm attaching config.log and my modified Portfile. Note that since I use the github portgroup the sources are in fact not being fetched via git, but downloaded as a tarball and do not contain a complete git history. Maybe rose requires to be built from a git repository? Can this requirement be lifted by providing the VERSION file?

[neverpanic (Clemens Lang)]

config.log from buildTree/

[neverpanic (Clemens Lang)]

Feel free to re-open.