Opened 8 years ago

Closed 8 years ago

#32941 closed enhancement (fixed)

Quicksilver: use tarball

Reported by: ryandesign (Ryan Schmidt) Owned by: singingwolfboy@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: Quicksilver

Description

In r89093 I updated Quicksilver to use the new github portgroup. Is there a reason why Quicksilver is fetching from git and not from a tarball? It seems to build and run fine using a tarball. Here's a patch that would do that. Let me know if there's any reason not to commit this.

Attachments (1)

Quicksilver.diff (564 bytes) - added by ryandesign (Ryan Schmidt) 8 years ago.
proposed patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: Quicksilver.diff added

proposed patch

comment:1 Changed 8 years ago by singingwolfboy@…

Resolution: invalid
Status: newclosed

That patch doesn't work: Macports doesn't know where to download the file from. When you test the patch to see if it works, make sure you run sudo port clean --all Quicksilver if you're doing changes to how the sources are fetched -- otherwise, Macports will use the already-downloaded source files still sitting on your hard drive.

comment:2 Changed 8 years ago by ryandesign (Ryan Schmidt)

Resolution: invalid
Status: closedreopened

I did of course verify the patch works correctly on my system before submitting it to you. :) Informing MacPorts where tarballs can be downloaded from is one of the features the github portgroup offers. If it's not working for you, could you please "sudo port selfupdate" and try again, and if it still fails, show me the error message you're getting?

comment:3 Changed 8 years ago by singingwolfboy@…

Resolution: fixed
Status: reopenedclosed

Ah, I see -- I had an old copy of the Quicksilver portfile lying in my local ports tree, which didn't have the github portgroup attached. Once I pulled the latest version of the portfile from the SVN repository and applied your patch, it worked fine. Committed in r89184.

Note: See TracTickets for help on using tickets.