Opened 12 years ago
Closed 12 years ago
#32942 closed enhancement (fixed)
phpsh: use tarball
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | singingwolfboy@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.3 |
| Keywords: | haspatch | Cc: | |
| Port: | phpsh |
Description
In r89095 I updated phpsh to use the new github portgroup. Is there a reason why this port is fetching from git and not from a tarball? It seems to build fine using a tarball. Here's a patch that would do that. Let me know if there's any reason not to commit this.
Attachments (1)
Change History (4)
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | phpsh.diff added |
|---|
comment:1 Changed 12 years ago by singingwolfboy@…
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
That patch doesn't work: Macports doesn't know where to download the file from. When you test the patch to see if it works, make sure you run `sudo port clean --all phpsh` if you're doing changes to how the sources are fetched -- otherwise, Macports will use the already-downloaded source files still sitting on your hard drive.
comment:2 Changed 12 years ago by singingwolfboy@…
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
I was mistaken -- this patch does work, after all. Committed in r89185.
comment:3 Changed 12 years ago by singingwolfboy@…
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
proposed patch