Opened 8 years ago

Closed 8 years ago

#32942 closed enhancement (fixed)

phpsh: use tarball

Reported by: ryandesign (Ryan Schmidt) Owned by: singingwolfboy@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: phpsh

Description

In r89095 I updated phpsh to use the new github portgroup. Is there a reason why this port is fetching from git and not from a tarball? It seems to build fine using a tarball. Here's a patch that would do that. Let me know if there's any reason not to commit this.

Attachments (1)

phpsh.diff (863 bytes) - added by ryandesign (Ryan Schmidt) 8 years ago.
proposed patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: phpsh.diff added

proposed patch

comment:1 Changed 8 years ago by singingwolfboy@…

Resolution: invalid
Status: newclosed

That patch doesn't work: Macports doesn't know where to download the file from. When you test the patch to see if it works, make sure you run `sudo port clean --all phpsh` if you're doing changes to how the sources are fetched -- otherwise, Macports will use the already-downloaded source files still sitting on your hard drive.

comment:2 Changed 8 years ago by singingwolfboy@…

Resolution: invalid
Status: closedreopened

I was mistaken -- this patch does work, after all. Committed in r89185.

comment:3 Changed 8 years ago by singingwolfboy@…

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.