Opened 8 years ago

Closed 8 years ago

#33128 closed update (fixed)

ntfs-3g 2011.4.12 update

Reported by: anddam (Andrea D'Amore) Owned by: petri@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: pixilla (Bradley Giesbrecht)
Port: ntfs-3g

Description

I'm attaching patch to update the port to 2012.1.15, latest version. Please confirm it works as expected.

Attachments (3)

patch-port_ntfs_3g.diff (1.7 KB) - added by anddam (Andrea D'Amore) 8 years ago.
Portfile (2.4 KB) - added by petri@… 8 years ago.
New Portfile; updated maintainer e-mail
Portfile.new.diff (2.4 KB) - added by petri@… 8 years ago.

Download all attachments as: .zip

Change History (16)

Changed 8 years ago by anddam (Andrea D'Amore)

Attachment: patch-port_ntfs_3g.diff added

comment:1 Changed 8 years ago by petri@…

I'm removing the line to delete mkfs.ntfs as ntfsprogs is rplaced by ntfs-3g. Also changing my email address in the port. Will retest.

comment:2 Changed 8 years ago by petri@…

Sorry, that line was supposed to be there. Anyway, attaching the new Portfile when having made sure it seems OK, as I managed to rm the previous version, so can't make a diff and can't figure out how to rsync it back.

Changed 8 years ago by petri@…

Attachment: Portfile added

New Portfile; updated maintainer e-mail

comment:3 Changed 8 years ago by pixilla (Bradley Giesbrecht)

Owner: changed from petri@… to petri@…

comment:4 in reply to:  2 Changed 8 years ago by pixilla (Bradley Giesbrecht)

Replying to petri@…:

I managed to rm the previous version, so can't make a diff and can't figure out how to rsync it back.

I have not used rsync in a while. Does it work to move the new "Portfile" to say "Portfile.new" and perform a "port sync"?

comment:5 Changed 8 years ago by pixilla (Bradley Giesbrecht)

Cc: pixilla@… added

Cc Me!

comment:6 in reply to:  2 ; Changed 8 years ago by anddam (Andrea D'Amore)

Replying to petri@…:

Sorry, that line was supposed to be there. Anyway, attaching the new Portfile when having made sure it seems OK, as I managed to rm the previous version, so can't make a diff and can't figure out how to rsync it back.

I wouldn't drop an error if mount.ntfs is present, I suggest to either put the code to rename mount.ntfs in that if block, so to correctly handle mount.ntfs presence, or to totally remove the check itself change the Portfile again if needed.

Also I see you've reverted dependency on port macfuse rather than fuse4x and removed license, probably you used a different Portfile version as base for editing. If you need the Portfile you have several options: you can download the Portfile I initially attached, perform a sync as Brad suggested or check the repository browser to see current portfile and its revisions.

comment:7 in reply to:  6 Changed 8 years ago by petri@…

Replying to and.damore@…:

I wouldn't drop an error if mount.ntfs is present, I suggest to either put the code to rename mount.ntfs in that if block, so to correctly handle mount.ntfs presence, or to totally remove the check itself change the Portfile again if needed.

I think mount.ntfs is something foreign, can I check for whether a previous port version has had the file on a particular ports install in some way (i.e., whether to touch the file, otherwise the option I'd go for would be to just mention it being there, perhaps as a vestigial item from an ancient ntfs-3g Portfile)?

Also I see you've reverted dependency on port macfuse rather than fuse4x and removed license, probably you used a different Portfile version as base for editing. If you need the Portfile you have several options: you can download the Portfile I initially attached, perform a sync as Brad suggested or check the repository browser to see current portfile and its revisions.

No, syncing (even after rm -rf:ing fuse/ntfs-3g) didn't help, but thanks for the repo browser link.

comment:8 Changed 8 years ago by petri@…

Gah, ignore my question in the first paragraph. Too much blood in my caffeine system.

comment:9 in reply to:  8 Changed 8 years ago by anddam (Andrea D'Amore)

Replying to petri@…:

Too much blood in my caffeine system.

I got a patch for that too.

Anyway if you don't know what mount.ntfs is and it's not in created at build time just skim the related lines from the Portfile. As soon as you give the clear-to-go we can commit it.

comment:10 Changed 8 years ago by anddam (Andrea D'Amore)

Type: defectupdate

Can you give feedback about mount.ntfs question so we can commit?

comment:11 Changed 8 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: newclosed

Committed r89790, taking advantage of maintainer timeout.

comment:12 Changed 8 years ago by petri@…

Resolution: fixed
Status: closedreopened

Actually, the mount.ntfs-3g was installed by previous package versions and should it become installed in new versions, the file ought to me renamed to conform to mount_xyz naming in OS X. The ntfsprogs isn't mentioned in the description so I deleted the deletion of mkfs.ntfs, nor is the correct maintainer address correct, so I'm reopening and attaching the new diff. Sorry about the delay, have been busy with other things for a while.

Changed 8 years ago by petri@…

Attachment: Portfile.new.diff added

comment:13 Changed 8 years ago by anddam (Andrea D'Amore)

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.