Opened 7 years ago

Closed 5 years ago

#34461 closed enhancement (fixed)

git-core - make the Portfile independent of the installed version of Perl

Reported by: BjarneDMat Owned by: ci42
Priority: Normal Milestone:
Component: ports Version: 2.1.0
Keywords: haspatch Cc: nonstop.server@…, cooljeanius (Eric Gallager)
Port: git-core

Description

I had upgraded completely to Perl 5.14 & removed every trace of Perl 5.12 from my computers

However, Perl 5.12 is hardcoded into the Portfile for git-core.

The attached patch-Portfile makes git-core independent of which version of Perl is installed.

Attachments (2)

patch-Portfile.diff (1.5 KB) - added by BjarneDMat 7 years ago.
patch to make git-core independen of installed version of Perl
Portfile-git-core.diff (2.6 KB) - added by dan@… 6 years ago.
Portfile diffs add perl_12|14|16 variants

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by BjarneDMat

Attachment: patch-Portfile.diff added

patch to make git-core independen of installed version of Perl

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

There are tons of ports that depend specifically on perl 5.12 modules.

The changes proposed in this patch look unusual to me; I'm not aware of us doing anything similar in any other ports.

comment:2 Changed 7 years ago by BjarneDMat

p5-dbd-mysql is already using this system, which is where I originally got the idea to this from ;-)

I've proposed this change for sql-grey too in #34357

In my opinion - unless it's explicitly required of the port - then ports ought to be independent of which version of Perl is the major one.

comment:3 in reply to:  2 Changed 7 years ago by cmconnelly (Claire Connelly)

Replying to macintosh@…:

In my opinion - unless it's explicitly required of the port - then ports ought to be independent of which version of Perl is the major one.

Completely agree. I don't need multiple versions of Perl lying around, especially if there's no actual dependency on a specific version of Perl. Same goes for Python, Ruby, and other languages.

comment:4 Changed 7 years ago by nonstop.server@…

Cc: nonstop.server@… added

Cc Me!

comment:5 Changed 7 years ago by jmroot (Joshua Root)

This doesn't work right; you need to set a variant to distinguish which version of perl is used.

comment:6 in reply to:  5 ; Changed 7 years ago by BjarneDMat

Replying to jmr@…:

This doesn't work right; you need to set a variant to distinguish which version of perl is used.

I'm sorry, but your statement is not correct.
It works perfectly in all instances I've used it.

Having said that, this ticket has to bee marked 'wont-fix' or 'duplicate' as it's superceeded by #34617

comment:7 in reply to:  6 Changed 7 years ago by ci42

Owner: changed from macports-tickets@… to ciserlohn@…
Status: newassigned

Replying to macintosh@…:

Having said that, this ticket has to bee marked 'wont-fix' or 'duplicate' as it's superceeded by #34617

I don't see that your proposed patch has been accepted.

However, If I have some spare time I will provide variants for perl5.14/perl5.16. Until I'll have implemented these variants this ticket remains open.

comment:8 Changed 7 years ago by ci42

Cc: ciserlohn@… removed

comment:9 in reply to:  6 Changed 7 years ago by jmroot (Joshua Root)

Replying to macintosh@…:

I'm sorry, but your statement is not correct.
It works perfectly in all instances I've used it.

Then your testing has been insufficient. Example: Build an archive of git-core on a machine with only perl5.12 installed, then install it on a machine with only perl5.14 installed. None of the perl-using bits will work.

This can happen because "git-core-1.7.11.5_0.darwin_11.x86_64.tbz2" is produced in both cases. If there was a variant controlling which perl to use, it would be e.g. "git-core-1.7.11.5_0+perl512.darwin_11.x86_64.tbz2" vs "git-core-1.7.11.5_0+perl514.darwin_11.x86_64.tbz2", and only the matching archive would be installed.

comment:10 Changed 6 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

Changed 6 years ago by dan@…

Attachment: Portfile-git-core.diff added

Portfile diffs add perl_12|14|16 variants

comment:11 Changed 6 years ago by dan@…

Added a patch to add perl_12, perl_14, and perl_16 variants to the git-core Portfile. Most of the Portfile changes were cut and pasted from the intltool Portfile.

Test builds worked for me with several variant combinations.

Adding it here if its useful to anyone since the last discussion on this ticket was 14 months ago and I'm apparently on a crusade to keep all but one perl5_16 out my new macports install.

comment:12 Changed 5 years ago by ci42

Resolution: fixed
Status: assignedclosed

Variants for perl 5.12 (default), 5.14 and 5.16 added in r114984.

Note: See TracTickets for help on using tickets.