Opened 7 years ago

Closed 7 years ago

#35452 closed defect (fixed)

texlive-bin fails to build on 10.4.11, G3

Reported by: tobia.tesan@… Owned by: drkp (Dan Ports)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: tiger haspatch Cc: ccarey@…, ryandesign (Ryan Schmidt)
Port: texlive-bin

Description (last modified by ryandesign (Ryan Schmidt))

Password:
--->  Computing dependencies for texlive-bin
--->  Building texlive-bin
Error: org.macports.build for port texlive-bin returned: command execution failed
Please see the log file for port texlive-bin for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_tex_texlive-bin/texlive-bin/main.log
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port texlive-bin failed

Attachments (2)

main.log (81.3 KB) - added by tobia.tesan@… 7 years ago.
build log
putil.cpp.diff (920 bytes) - added by ccarey@… 7 years ago.
patch to libs/icu/icu-49.1/common/putil.cpp to allow texlive-bin @2012_4 +no_x11 to build successfully on Tiger

Download all attachments as: .zip

Change History (13)

Changed 7 years ago by tobia.tesan@…

Attachment: main.log added

build log

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)
Keywords: tiger added
Owner: changed from macports-tickets@… to dports@…

Please remember to use WikiFormatting.

The log says:

error: ‘localtime_r’ was not declared in this scope

This error was noted before on our mailing list, unfortunately without a solution.

comment:2 Changed 7 years ago by tobia.tesan@…

Oh, I see. That's too bad.

I would be glad to give more constructive help, but I don't know the first thing about that codebase, much less where localtime_r() is expected to be found or what it does.

Any hints about where should I begin to look?

Can the upstream mantainers shed any light about the subject?

Doesn't sound like a super hardcore bug.

comment:3 Changed 7 years ago by jmroot (Joshua Root)

localtime_r should be declared in time.h and implemented in libSystem.

Last edited 7 years ago by jmroot (Joshua Root) (previous) (diff)

comment:4 Changed 7 years ago by jmroot (Joshua Root)

And indeed libs/icu/icu-49.1/common/putil.cpp doesn't include time.h.

comment:5 Changed 7 years ago by drkp (Dan Ports)

I don't have a Tiger machine anymore; can someone who does try adding #include <time.h> to libs/icu/icu-49.1/common/putil.cpp and see if it builds now?

comment:6 Changed 7 years ago by drkp (Dan Ports)

Also, I wonder if the icu port has the same issue now that it's been updated to 49.1...

Changed 7 years ago by ccarey@…

Attachment: putil.cpp.diff added

patch to libs/icu/icu-49.1/common/putil.cpp to allow texlive-bin @2012_4 +no_x11 to build successfully on Tiger

comment:7 in reply to:  6 Changed 7 years ago by ccarey@…

Replying to dports@…:

Also, I wonder if the icu port has the same issue now that it's been updated to 49.1...

The patch for icu @49.1.2_0 on Tiger in #36495 also lets texlive-bin @2012_4 +no_x11 build successfully on Tiger; a patch suited for texlive-bin is attached above. (There are minor differences between the putil.cpp file in icu and the one in texlive-bin, but those differences don't affect the patch.)

The same caveats that were noted in the description of #36495 apply to this patch, too. This patch works on Tiger, but I don’t know if it might cause any problems on Leopard and newer. If you have access to machines running Leopard or newer, please compile texlive-bin with this patch on those machines before integrating this patch into this MacPorts port. (I compiled with +no_x11 on my machine, but compiling with or without X11 should not make a difference with this patch.)

comment:8 in reply to:  2 Changed 7 years ago by ccarey@…

Replying to tobia.tesan@…:

Doesn't sound like a super hardcore bug.

It wasn’t. Please add haspatch to this ticket’s keywords.

comment:9 in reply to:  4 Changed 7 years ago by ccarey@…

Replying to jmr@…:

And indeed libs/icu/icu-49.1/common/putil.cpp doesn't include time.h.

Line 119 in that file suggests otherwise.

comment:10 Changed 7 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added

comment:11 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ccarey@… ryandesign@… added
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.