inkscape 0.48.3.1 fails to build against libpng 1.5

[hugo-ribeiro (Hugo Ribeiro)]

Here's the error

In file included from sp-image.cpp:59:
/opt/local/include/lcms.h: In function ‘void* _cmsMalloc(size_t)’:
/opt/local/include/lcms.h:1418: warning: comparison of unsigned expression < 0 is always false
sp-image.cpp: In function ‘bool Inkscape::IO::readPngAndHeaders(Inkscape::IO::PushPull&, gint&, gint&)’:
sp-image.cpp:401: error: invalid conversion from ‘char**’ to ‘png_byte**’
sp-image.cpp:401: error:   initializing argument 5 of ‘png_uint_32 png_get_iCCP(const png_struct*, const png_info*, char**, int*, png_byte**, png_uint_32*)’
sp-image.cpp: In function ‘void sp_image_release(SPObject*)’:
sp-image.cpp:676: warning: ‘gdk_pixbuf_unref’ is deprecated (declared at /opt/local/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243)
sp-image.cpp:676: warning: ‘gdk_pixbuf_unref’ is deprecated (declared at /opt/local/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243)
sp-image.cpp: In function ‘void sp_image_update(SPObject*, SPCtx*, unsigned int)’:
sp-image.cpp:836: warning: ‘gdk_pixbuf_unref’ is deprecated (declared at /opt/local/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243)
sp-image.cpp:836: warning: ‘gdk_pixbuf_unref’ is deprecated (declared at /opt/local/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243)
sp-image.cpp: In function ‘GdkPixbuf* sp_image_pixbuf_force_rgba(GdkPixbuf*)’:
sp-image.cpp:1294: warning: ‘gdk_pixbuf_unref’ is deprecated (declared at /opt/local/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243)
sp-image.cpp:1294: warning: ‘gdk_pixbuf_unref’ is deprecated (declared at /opt/local/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243)
  CXX    sp-item.o
make[2]: *** [sp-image.o] Error 1
make[2]: *** Waiting for unfinished jobs....
sp-item.cpp: In function ‘void clip_ref_changed(SPObject*, SPObject*, SPItem*)’:
sp-item.cpp:571: warning: ‘sp_item_invoke_bbox’ is deprecated (declared at sp-item.h:213)
sp-item.cpp: In function ‘void mask_ref_changed(SPObject*, SPObject*, SPItem*)’:
sp-item.cpp:599: warning: ‘sp_item_invoke_bbox’ is deprecated (declared at sp-item.h:213)
sp-item.cpp: In function ‘void sp_item_update(SPObject*, SPCtx*, guint)’:
sp-item.cpp:635: warning: ‘sp_item_invoke_bbox’ is deprecated (declared at sp-item.h:213)
sp-item.cpp: In function ‘NRArenaItem* sp_item_invoke_show(SPItem*, NRArena*, unsigned int, unsigned int)’:
sp-item.cpp:1133: warning: ‘sp_item_invoke_bbox’ is deprecated (declared at sp-item.cpp:757)
sp-item.cpp:1152: warning: ‘sp_item_invoke_bbox’ is deprecated (declared at sp-item.cpp:757)
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_inkscape/inkscape/work/inkscape-0.48.3.1" && /usr/bin/make -j2 -w all 
Exit code: 2
Error: org.macports.build for port inkscape returned: command execution failed

There is a similar ​thread on the inkscape bug tracker. The proposed patch might also fix the issue here. If yes, can the patch be included into the port?

Another solution is also reported in the "linux from scratch" ​handbook.

[royliu@…]

I may have already fixed this in #97391.

[royliu@…]

Sorry, I meant r97391.

[royliu@…]

I can confirm that this is fixed.