Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#38451 closed enhancement (fixed)

RFE: add a callback to automatically add a dependency on gmake when using build.type gnu on platforms where gnumake is not the default

Reported by: cooljeanius (Eric Gallager) Owned by: macports-tickets@…
Priority: Low Milestone:
Component: base Version: 2.1.3
Keywords: Cc: larryv (Lawrence Velázquez)
Port:

Description

This was originally brought up in comment:ticket:38279:6 by larryv. See how BSD Make does it for reference.

Change History (9)

comment:1 Changed 10 years ago by afb@…

The handling of "bsdmake" seems strange, since the code uses "make" on FreeBSD and "pmake" on Linux.

Anyway, the path to the various makes are set when doing the ./configure so doing it in build is a tad late.

comment:2 in reply to:  1 ; Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to afb@…:

The handling of "bsdmake" seems strange, since the code uses "make" on FreeBSD and "pmake" on Linux.

I think the default Make on FreeBSD is BSD Make, while on Linux it’s installed as “pmake”.

Anyway, the path to the various makes are set when doing the ./configure so doing it in build is a tad late.

The code in portbuild is evaluated before any phases are performed. The build.cmd option just determines the command that is run as part of the build phase.

comment:3 Changed 10 years ago by larryv (Lawrence Velázquez)

Priority: NormalLow

I daresay most platforms have GNU Make by default.

comment:4 in reply to:  2 Changed 10 years ago by afb@…

Replying to larryv@…:

The handling of "bsdmake" seems strange, since the code uses "make" on FreeBSD and "pmake" on Linux.

I think the default Make on FreeBSD is BSD Make, while on Linux it’s installed as “pmake”.

Forgot that the code isn't for other platforms, it's for installing bsdmake on Mac OS X when it is missing... (#33355)

We could add a similar block for FreeBSD where gmake is "supposed" to be installed, but then removed or something.

comment:5 in reply to:  3 Changed 10 years ago by afb@…

Replying to larryv@…:

I daresay most platforms have GNU Make by default.

Yes, especially with #12247 requiring it, in order to build base...

bsdmake: fatal errors encountered -- cannot continue

comment:6 Changed 10 years ago by afb@…

Resolution: fixed
Status: newclosed

Fixed, r104303.

comment:7 Changed 10 years ago by cooljeanius (Eric Gallager)

Thanks!

comment:8 Changed 10 years ago by jmroot (Joshua Root)

Neither gmake nor bsdmake should need an explicit depends_skip_archcheck, since they both set installs_libs no.

comment:9 in reply to:  8 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to jmr@…:

Neither gmake nor bsdmake should need an explicit depends_skip_archcheck, since they both set installs_libs no.

r104463

Note: See TracTickets for help on using tickets.