Opened 4 years ago

Closed 3 years ago

#39883 closed update (fixed)

choqok: update to 1.4

Reported by: kurthindenburg (Kurt Hindenburg) Owned by: mkae (Marko Käning)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: choqok

Description (last modified by mf2k (Frank Schima))

A followup to #39877, this Portfile is for choqok 1.3 - it builds and installs but doesn't find the plugin for the config dialog.

I'm sure I doing something wrong especially having to specify /Applications/Macports/KDE4

choqok(68693)/kdecore (trader) KServiceTypeTrader::defaultOffers: KServiceTypeTrader: serviceType  "Choqok/Plugin"  not found 

Attachments (3)

Portfile (1.4 KB) - added by kurthindenburg (Kurt Hindenburg) 4 years ago.
Portfile-0.4 (970 bytes) - added by kurthindenburg (Kurt Hindenburg) 4 years ago.
Diff from the 0.4 version - the 0.4 doesn't even build here
Portfile.diff (1.5 KB) - added by kurthindenburg (Kurt Hindenburg) 4 years ago.
Correct 2 issues - thanks

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

comment:1 Changed 4 years ago by mf2k (Frank Schima)

  • Description modified (diff)
  • Summary changed from request update port kde/choqok 1.3 w/ Portfile to choqok: update to 1.3
  • Type changed from request to update
  • Version 2.2.0 deleted

Please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing.

In the future, please use WikiFormatting.

Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Diff from the 0.4 version - the 0.4 doesn't even build here

comment:2 Changed 4 years ago by ryandesign (Ryan Schmidt)

Some observations:

  • You should not remove or edit the "$Id$" line.
  • You don't need to add "distfiles ${name}-${version}.tar.bz2"; that's the default.
  • You should change "master_sites sourceforge:${name} " to avoid redirects.
  • You don't need "configure.cmd cmake"; the cmake portgroup does that for you.
  • You should append to (not overwrite) dependencies so that you don't inadvertently replace the dependencies the portgroup(s) already set for you.

comment:3 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Here's an update to 1.4 that actually works w/ Twitter - I'm not sure what the last point in comment #2 refers to. And it looks like I need to still fix observation #2.

comment:4 Changed 4 years ago by mf2k (Frank Schima)

  • The distfiles line should be deleted entirely because it is the default.
  • The word "depends-build" should be replaced by "depends-lib-append" since those all look like they are needed to run - not simply build - the port. The "-append" part is to not overwrite dependencies added by the cmake and kde4 portgroups.

Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Correct 2 issues - thanks

comment:5 follow-up: Changed 3 years ago by mkae (Marko Käning)

  • Owner changed from macports-tickets@… to mk@…

Hi Kurt, the diff references a del qoauth which I can't seem to find these days on MacPorts. Greets, Marko

comment:6 Changed 3 years ago by mkae (Marko Käning)

  • Summary changed from choqok: update to 1.3 to choqok: update to 1.4

comment:7 in reply to: ↑ 5 Changed 3 years ago by mkae (Marko Käning)

Replying to mk@…:

Hi Kurt, the diff references a del qoauth which I can't seem to find these days on MacPorts. Greets, Marko

Ah, ok, only now I saw #39877. :-)

comment:8 Changed 3 years ago by mkae (Marko Käning)

  • Resolution set to fixed
  • Status changed from new to closed

Committed in r119717.

Note: See TracTickets for help on using tickets.