Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#41101 closed defect (fixed)

tcpreplay @3.4.4 failed to build due to strlcat/strcpy on OS X.9

Reported by: agm650 Owned by: Gminfly
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: mavericks haspatch Cc: sck@…, vincent.passaro@…, ericmoret, jms@…, nerdling (Jeremy L)
Port: tcpreplay

Description

sudo port install tcpreplay
--->  Computing dependencies for tcpreplay
--->  Fetching archive for tcpreplay
--->  Attempting to fetch tcpreplay-3.4.4_0.darwin_13.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/tcpreplay
--->  Attempting to fetch tcpreplay-3.4.4_0.darwin_13.x86_64.tbz2 from http://lil.fr.packages.macports.org/tcpreplay
--->  Attempting to fetch tcpreplay-3.4.4_0.darwin_13.x86_64.tbz2 from http://packages.macports.org/tcpreplay
--->  Fetching distfiles for tcpreplay
--->  Verifying checksums for tcpreplay
--->  Extracting tcpreplay
--->  Configuring tcpreplay
--->  Building tcpreplay
Error: org.macports.build for port tcpreplay returned: command execution failed
Please see the log file for port tcpreplay for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_tcpreplay/tcpreplay/main.log
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port tcpreplay failed

Apparently, same issue as in ticket #40763

Adding the following to the CFLAGS seems to solve the issue:

-D_FORTIFY_SOURCE=0

Attachments (3)

tcp_replay_main.log (44.0 KB) - added by agm650 6 years ago.
main.log
Portfile (1.5 KB) - added by agm650 6 years ago.
Modified Portfile for tcpreplay
tcpreplay_maverick.patch (422 bytes) - added by agm650 6 years ago.
diff result

Download all attachments as: .zip

Change History (18)

Changed 6 years ago by agm650

Attachment: tcp_replay_main.log added

main.log

Changed 6 years ago by agm650

Attachment: Portfile added

Modified Portfile for tcpreplay

comment:1 Changed 6 years ago by ryandesign (Ryan Schmidt)

Keywords: mavericks haspatch added
Owner: changed from macports-tickets@… to pmq@…

We would prefer a unified diff of your Portfile changes instead of a complete new Portfile.

Changed 6 years ago by agm650

Attachment: tcpreplay_maverick.patch added

diff result

comment:2 Changed 6 years ago by sck@…

Cc: sck@… added

Cc Me!

comment:3 Changed 6 years ago by vincent.passaro@…

Cc: vincent.passaro@… added

Cc Me!

comment:4 Changed 6 years ago by vincent.passaro@…

Cc: vincent.passaro@… removed

Cc Me!

comment:5 Changed 6 years ago by vincent.passaro@…

Cc: vincent.passaro@… added

Cc Me!

comment:6 Changed 6 years ago by vincent.passaro@…

Error seems to still linger.....

comment:7 Changed 6 years ago by ericmoret

Cc: eric.moret@… added

Cc Me!

comment:8 Changed 6 years ago by wayne.veilleux@…

Sorry, I'm a little bit new to Macports. I run Maverick. I applied the tcpreplay_maverick.patch​ patch on /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/net/tcpreplay/Portfile and what should I do after ? I tried a "sudo port install tcpreplay" and I still have the error: "checking for library containing pcap_close... no \ configure: error: Unable to link libpcap in /opt/local" and failed to install tcpreplay. Thanks for any help !

comment:9 Changed 6 years ago by agm650

In your config.log (/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_tcpreplay/tcpreplay/work/tcpreplay-3.4.4/config.log) do you have some errors regarding dbus? Something like that:

configure:17394: checking for library containing pcap_close
configure:17425: /usr/bin/clang -o conftest -D_U_="__attribute__((unused))" -pipe -Os -arch x86_64 -Wall -O3 -std=gnu99    -I/opt/local/include -I/opt/local/include -L/opt/local/lib -Wl,-headerpad_max_install_names -arch x86_64 conftest.c /opt/local/lib/libpcap.a >&5
Undefined symbols for architecture x86_64:
  "_dbus_bus_add_match", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
  "_dbus_bus_get", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
  "_dbus_bus_register", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
  "_dbus_connection_flush", referenced from:
      _dbus_write in libpcap.a(pcap-dbus.o)
  "_dbus_connection_open", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
  "_dbus_connection_pop_message", referenced from:
      _dbus_read in libpcap.a(pcap-dbus.o)
  "_dbus_connection_read_write", referenced from:
      _dbus_read in libpcap.a(pcap-dbus.o)
  "_dbus_connection_send", referenced from:
      _dbus_write in libpcap.a(pcap-dbus.o)
  "_dbus_connection_set_max_received_size", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
  "_dbus_connection_unref", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
  "_dbus_error_free", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
      _dbus_write in libpcap.a(pcap-dbus.o)
  "_dbus_error_is_set", referenced from:
      _dbus_activate in libpcap.a(pcap-dbus.o)
  "_dbus_free", referenced from:
      _dbus_read in libpcap.a(pcap-dbus.o)
  "_dbus_message_demarshal", referenced from:
      _dbus_write in libpcap.a(pcap-dbus.o)
  "_dbus_message_is_signal", referenced from:
      _dbus_read in libpcap.a(pcap-dbus.o)
  "_dbus_message_marshal", referenced from:
      _dbus_read in libpcap.a(pcap-dbus.o)
  "_dbus_message_unref", referenced from:
      _dbus_write in libpcap.a(pcap-dbus.o)
ld: symbol(s) not found for architecture x86_64

I had to reinstall macports on a laptop and I'm facing the same issue. but according to the config.log I think I have an error with dbus or libpcap, not "yet" tcpreplay.

comment:10 Changed 5 years ago by jms@…

Hi all. So... how does this fix get put back into the port library? I'd be happy to do the work if someone could point me at a general round of instructions for such things. It looks like there is a fix, but doing a normal "port install tcpreply" returns the error...

comment:11 Changed 5 years ago by jms@…

Cc: jms@… added

Cc Me!

comment:12 Changed 5 years ago by mf2k (Frank Schima)

Owner: changed from pmq@… to normen@…

Assigning to new maintainer.

comment:13 Changed 5 years ago by nerdling (Jeremy L)

Cc: snc@… added
Resolution: fixed
Status: newclosed

Updated in r121135.

comment:14 Changed 5 years ago by nerdling (Jeremy L)

Maintainer fixed in r121136.

comment:15 Changed 5 years ago by jmroot (Joshua Root)

Fixed properly in r121309.

Note: See TracTickets for help on using tickets.