Opened 8 years ago

Closed 8 years ago

#44282 closed defect (fixed)

patch to enable ktimetracker in kdepim4

Reported by: RJVB (René Bertin) Owned by: NicosPavlov
Priority: Normal Milestone:
Component: ports Version: 2.3.1
Keywords: haspatch Cc: bjoern.ricks@…, mkae (Marko Käning)
Port: kdepim4

Description

Attached is a patch that enables the building of ktimetracker in kdepim4 . This component ought to build and work even with the XScreenSaver library available. It does indeed build, but the command fails with the error "Could not create the KTimeTracker part.", with the additional reason "m_part is 0" printed on stderr. Debugging that is beyond me ATM, so if someone else could have a look?

Attachments (3)

enable-ktimetracker.patch (784 bytes) - added by RJVB (René Bertin) 8 years ago.
portfile.diff (1.0 KB) - added by RJVB (René Bertin) 8 years ago.
fix-ktimetracker.patch (7.1 KB) - added by RJVB (René Bertin) 8 years ago.

Download all attachments as: .zip

Change History (14)

Changed 8 years ago by RJVB (René Bertin)

Attachment: enable-ktimetracker.patch added

Changed 8 years ago by RJVB (René Bertin)

Attachment: portfile.diff added

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Cc: bjoern.ricks@… added; nicos@… removed
Keywords: haspatch added; ktimetracker kpart load failure removed
Owner: changed from macports-tickets@… to nicos@…

comment:2 Changed 8 years ago by NicosPavlov

I am far from sure that the Macports tickets are the right place for this. It is not a Macports issue to the best of my understanding, especially since you are modifying the build scripts to enable a module which is apparently for X11, which is not supported by qt4-mac, as it is based on aqua.

If you are trying to port a module, kde-devel would probably be a far better place to get help on this, as you have no guarantee that people reading this ticket are KDE developers (I am not).

comment:3 Changed 8 years ago by RJVB (René Bertin)

I am far from sure that the Macports tickets are the right place for this. It is not a Macports issue to the best of my understanding, especially

True. If the kpart worked perfectly I'd have submitted the patch to BKO, but as it is I think there's more chance to get some feedback on why it doesn't in the MacPorts community than elsewhere...

since you are modifying the build scripts to enable a module which is apparently for X11, which is not supported by qt4-mac, as it is based on aqua.

ktimetracker uses an X11 subsystem for timing, but has been conceived to function without it. The rest is pure KDE and should work with qt4-mac

If you are trying to port a module, kde-devel would probably be a far better place to get help on this, as you have no guarantee that people reading this ticket are KDE developers (I am not).

Why would one assume that you're the only one reading these tickets? :P In fact (and correct me if I'm wrong), I assume that most KDE-mac developers will be using MacPorts... (also, trac.macports uses a formatting system that makes it easier to inline code snippets than on BKO, IIRC)

comment:4 in reply to:  3 Changed 8 years ago by mkae (Marko Käning)

Cc: mk@… added

Replying to rjvbertin@…:

In fact (and correct me if I'm wrong), I assume that most KDE-mac developers will be using MacPorts

Well, I wouldn't be so sure about that. :)

I've actually spotted this ticket only because I opened our large KDE ticket table just now (which I do every now and then only)!

I am afraid it's better to bring this to the KDE-DEVEL mailing list.

comment:5 Changed 8 years ago by RJVB (René Bertin)

I've made some progress on getting ktimetracker to function under OS X. Part of the failure described above is due to an issue with the libical port, for which I uploaded a patch earlier today.

I'm attaching here a patchfile that enables idle time detection under OS X, the feature for which ktimetracker relies on XScreenSaver on Linux.

What remains to be done is to figure out why timing is off, i.e. too fast.

Changed 8 years ago by RJVB (René Bertin)

Attachment: fix-ktimetracker.patch added

comment:6 Changed 8 years ago by mkae (Marko Käning)

Any progress on the timing "being off", René?

comment:7 Changed 8 years ago by RJVB (René Bertin)

Ahem, I have a vague recollection that timing wasn't actually off. Also, this patch has been integrated "upstream" (https://git.reviewboard.kde.org/r/119533/). I cannot find a trace of that in the git/4.14 code, so in any event the attached patch will remain of interest for MacPorts.

comment:8 Changed 8 years ago by mkae (Marko Käning)

Oh, I see, it is indeed marked as submitted.

So, it didn't make it into KDE 4.14 anymore?

comment:9 Changed 8 years ago by RJVB (René Bertin)

Watch the RR on RB, I asked. It's possible that no one actually committed it - and I still don't have permission to do so.

comment:10 Changed 8 years ago by mkae (Marko Käning)

Hmm... OK, someone marked it as submitted. If it had been committed a month ago one should find the patch applied in kdepim's git by now.

comment:11 Changed 8 years ago by NicosPavlov

Resolution: fixed
Status: newclosed

Committed in r126437 along with 4.13.3 update.

Note: See TracTickets for help on using tickets.