Opened 5 years ago

Closed 5 years ago

#44307 closed defect (fixed)

py-pyepl: remove PIL dependency

Reported by: Ionic (Mihai Moldovan) Owned by: petrrr
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: py-pyepl

Description

py-pyepl doesn't make use of PIL at all (i.e., it's not importing it.)

There is a comment stating

#import PIL.Image  # catch error here!

but that's hardly sufficient to declare a dependency.

On the other hand, py-opengl, a dependency of py-pyepl does indeed need PIL/Pillow. py-opengl already correctly depends on PIL/Pillow (cf. #44284.)

Remove the PIL dependency from py-pyepl.

x-linking #44281

Attachments (1)

py-pyepl-remove-pil-dep.patch (821 bytes) - added by Ionic (Mihai Moldovan) 5 years ago.
Remove py*-pil dependency, not used by software. Revbump.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 years ago by petrrr

For me the port fails to build, and I doubt anyone really use it.

comment:2 in reply to:  1 Changed 5 years ago by Ionic (Mihai Moldovan)

Replying to petr@…:

For me the port fails to build, and I doubt anyone really use it.

Hopefully not due to my changes, though. :)

(Seen #44310, it looks totally unrelated. Just old and busted software.)

comment:3 Changed 5 years ago by petrrr

Unrelated! Probably the port is dead for years. But the registry change would probably deserve a rev.bump, and the buildbots will complain.

comment:4 Changed 5 years ago by Ionic (Mihai Moldovan)

Nah, there's no revbump required. The registry will be fine. It just records resolved dependencies, so stuff will stay the same for users who already have the ports installed.

Changed 5 years ago by Ionic (Mihai Moldovan)

Remove py*-pil dependency, not used by software. Revbump.

comment:5 Changed 5 years ago by Ionic (Mihai Moldovan)

Revbumped port to account for dependency change. (Even though it's still broken, whatever.)

comment:6 Changed 5 years ago by petrrr

Committed in r122244.

Ticket #44310 will deal with the build failure.

comment:7 Changed 5 years ago by petrrr

Owner: changed from macports-tickets@… to petr@…
Status: newassigned

comment:8 Changed 5 years ago by petrrr

Cc: petr@… removed
Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.