Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#46240 closed enhancement (fixed)

kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent

Reported by: RJVB (René Bertin) Owned by: mkae (Marko Käning)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: NicosPavlov, mkae (Marko Käning)
Port: kde4

Description

The kde4 1.1 PortGroup file contains hardcoded declarations for the QCA2 include and library directories. Those are inappropriate for qt4-mac +concurrent, and in my testing they are also not required.

Attachments (1)

PortGroup-kde4_1.1.diff (1.1 KB) - added by RJVB (René Bertin) 4 years ago.

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by RJVB (René Bertin)

Attachment: PortGroup-kde4_1.1.diff added

comment:1 Changed 4 years ago by mkae (Marko Käning)

Cc: mk@… added
Version: 2.3.3

comment:2 Changed 4 years ago by mkae (Marko Käning)

Sure that committing this won't break anything?

For me it's unclear how to test this without rebuilding whole kdelibs4 and perhaps port:konversation...

comment:3 Changed 4 years ago by mkae (Marko Käning)

Owner: changed from macports-tickets@… to mk@…

comment:4 Changed 4 years ago by RJVB (René Bertin)

This change won't require anything to be rebuilt. It removes instructions where to find QCA during a build. When I tried with the standard (traditional, exclusive) port:qt4-mac active those instructions were redundant (= not required), so removing them didn't break anything. For me.

Testing is simple enough: port -v configure foo where foo is any KDE4 port that depends on port:qca (or possibly port:qca-ossl). If that doesn't raise errors or warnings about something qca-related not being found you have your proof. You can also double-check in the generated CMakeCache.txt file if the qca stuff is found in the correct locations.

The reason that I like to have this committed is that PortGroup definitions outside the default repository apparently apply only to the ports in the same repository. Or maybe the rule is that a PortGroup definition in a port repository overrides PortGroup definitions from outside that repository.

comment:5 Changed 4 years ago by mkae (Marko Käning)

Since I wasn't sure what you really meant in your last paragraph (w.r.t. default and same), I removed these two lines in my base installation, as well as in the checked out port group definition in the corresponding dports directory and ended up with this:

-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
   * QCA - Qt Cryptographic Architecture

-----------------------------------------------------------------------------
-- Congratulations! All external packages have been found.
-----------------------------------------------------------------------------

meaning that a removal of these two options is possible. :-)

comment:6 Changed 4 years ago by mkae (Marko Käning)

BTW, your patch wasn't applicable as is, since the portgroup had changed in the meantime.

comment:7 Changed 4 years ago by mkae (Marko Käning)

Resolution: fixed
Status: newclosed

Done in r133738

comment:8 Changed 4 years ago by mkae (Marko Käning)

Thanks, René, for supplying just committed r133799.

Note: See TracTickets for help on using tickets.