Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#46558 closed update (fixed)

phonon-backend-gstreamer update to 4.8.2 and qt5 support

Reported by: RJVB (René Bertin) Owned by: mkae (Marko Käning)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: springermac (Jonathan Springer), mkae (Marko Käning), michaelld (Michael Dickens)
Port: phonon-backend-gstreamer

Description

This patch updates phonon-backend-gstreamer to the current version 4.8.2, and introduces the subport qt5-phonon-backend-gstreamer which builds the code for Qt5 .

Attachments (4)

Portfile (2.2 KB) - added by RJVB (René Bertin) 4 years ago.
A full Portfile is always safer O:)
PGBS-482.diff (2.8 KB) - added by RJVB (René Bertin) 4 years ago.
Oops, my bad. If I'd checked I'd have seen I wasn't diff'ing against the Portfile currently in MacPorts svn …
PBGS-482.diff (2.8 KB) - added by RJVB (René Bertin) 3 years ago.
main.log.gz (5.7 KB) - added by mkae (Marko Käning) 3 years ago.
Failing build with latest patch

Download all attachments as: .zip

Change History (35)

comment:1 Changed 4 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:2 Changed 4 years ago by springermac (Jonathan Springer)

Cc: springermac@… added

Cc Me!

comment:3 Changed 4 years ago by springermac (Jonathan Springer)

Could we make this depend on gstreamer1-gst-plugins-good instead of gstreamer1-gst-plugins-base so there is actual functionality out of the box?

comment:4 Changed 4 years ago by RJVB (René Bertin)

That's going to add quite a few dependencies, I see.

Since you appear to know these projects: are we talking about build dependencies or runtime dependencies?

If you are implying that the phonon gstreamer backend needs the "good plugins" in order to serve any purpose (i.e. produce even the simplest of beeps), then yes, it might be useful to pull in those instead of more minimum dependencies. If not and we're talking about runtime dependencies, it should maybe remain an optional addition.

comment:5 Changed 4 years ago by springermac (Jonathan Springer)

Yes the phonon-backend-gstreamer port needs the gstreamer1-gst-plugins-good port to be able to play or process any audio or video.

The phonon-backend-gstreamer port would depend only on the gstreamer1-gst-plugins-good port which depends on the gstreamer1-gst-plugins-base port and gstreamer1 port.

comment:6 Changed 4 years ago by RJVB (René Bertin)

I just installed port:gstreamer1-gst-plugins-good but the phonon examples still do nothing for me. Should phonon or the gstreamer backend be rebuilt with gstreamer1-gst-plugins-good in place?

Also, gstreamer1-gst-plugins-good depends on more than just gstreamer1-gst-plugins-base and gstreamer1, which was my point.

comment:7 Changed 4 years ago by RJVB (René Bertin)

See https://trac.macports.org/ticket/46658 . Do you have suggestions how to configure pulseaudio properly, or what other gstreamer plugin to use?

comment:8 Changed 4 years ago by springermac (Jonathan Springer)

Could you add this to at least the qt4 variant and the qt5 if you want?

post-destroot {
        file mkdir ${destroot}${qt_plugins_dir}
        copy ${destroot}${prefix}/lib/kde4/plugins/phonon_backend ${destroot}${qt_plugins_dir}
    }

comment:9 Changed 4 years ago by RJVB (René Bertin)

I'll have it make a symlink ${qt_plugins_dir}/phonon_backend -> ${prefix}/lib/kde4/plugins/phonon_backend . That's what I have on my end.

But not of the Qt5 version to KDE4. That doesn't make sense, and would most likely cause crashing.

comment:10 Changed 4 years ago by springermac (Jonathan Springer)

Sounds good. Thanks.

comment:11 Changed 4 years ago by springermac (Jonathan Springer)

The latest diff doesn't have the full changes and fails because ${destroot}${qt_plugins_dir} doesn't exist during destroot.

comment:12 Changed 4 years ago by springermac (Jonathan Springer)

Still fails because of the missing directory and it depends on gstreamer base instead of gstreamer good.

Otherwise looks good and works with qt4 (I haven't tried with qt5 yet).

comment:13 Changed 4 years ago by RJVB (René Bertin)

This one works for me (yeah, tested it this time...)

Changed 4 years ago by RJVB (René Bertin)

Attachment: Portfile added

A full Portfile is always safer O:)

Changed 4 years ago by RJVB (René Bertin)

Attachment: PGBS-482.diff added

Oops, my bad. If I'd checked I'd have seen I wasn't diff'ing against the Portfile currently in MacPorts svn ...

comment:14 Changed 4 years ago by RJVB (René Bertin)

Aligned the qt5 subport to the "suffix principle".

comment:15 Changed 4 years ago by mkae (Marko Käning)

Are there any consequences for this port due to #46552?

comment:16 Changed 4 years ago by RJVB (René Bertin)

No. The VLC and GStreamer backends can be installed together, and the multimedia KCM has a sheet to select between the 2. The GStreamer backend requires PulseAudio to work, though, which isn't the most appropriate way to create sound on OS X.

comment:17 Changed 4 years ago by mkae (Marko Käning)

OK, so, is this submission sufficiently tested and can be considered safe for committing?

comment:18 Changed 4 years ago by RJVB (René Bertin)

I hope so, and think that any potential issues with the Qt5 subport will only come to light once it's been allowed into the wild ...

comment:19 Changed 4 years ago by mkae (Marko Käning)

You've got a

replaced_by     ${name}-qt5 

set for port qt5-${name}.

This can be removed from the final portfile, as this was only locally needed on your end, I suppose.

Ports related to Qt5 on MacPorts are as of now:

$ port echo qt5-*
qt5-creator-mac                 
qt5-creator-mac-docs            
qt5-creator-mac-examples        
qt5-mac                         
qt5-mac-docs                    
qt5-mac-mysql56-plugin          
qt5-mac-psql84-plugin           
qt5-mac-sqlite3-plugin

I'll test whether it builds here on my Qt4 and Qt5 VMs and then commit the port. Thanks for taking care of this!

Last edited 4 years ago by mkae (Marko Käning) (previous) (diff)

comment:20 Changed 4 years ago by mkae (Marko Käning)

Cc: mk@… removed
Owner: changed from macports-tickets@… to mk@…

comment:21 Changed 4 years ago by mkae (Marko Käning)

OK, I guess, this can be committed as is, even with qt5-mac in its current non-concurrent state, right?

comment:22 Changed 4 years ago by RJVB (René Bertin)

I would think so.

comment:23 Changed 4 years ago by mkae (Marko Käning)

The patch file PGBS-482.diff isn't applying anymore as is, since the port has been updated to 4.8.2_1 in the meantime. René, can you have created a new portfile diff? (Ping)

Last edited 4 years ago by mkae (Marko Käning) (previous) (diff)

comment:24 Changed 3 years ago by mkae (Marko Käning)

What's the status of this port, actually?

I've found that the Qt4 version actually fails because it cannot find GST headers anymore.

I could create a separate ticket for now, if needed...

Last edited 3 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:25 Changed 3 years ago by RJVB (René Bertin)

Oops, apparently I missed this or completely forgot about it. Attaching a new diff.

Changed 3 years ago by RJVB (René Bertin)

Attachment: PBGS-482.diff added

Changed 3 years ago by mkae (Marko Käning)

Attachment: main.log.gz added

Failing build with latest patch

comment:26 Changed 3 years ago by mkae (Marko Käning)

Cc: mk@… added; michaelld@… removed
Owner: changed from mk@… to michaelld@…

Hi Michael, can you take over this one?

comment:27 in reply to:  24 Changed 3 years ago by ryandesign (Ryan Schmidt)

Replying to mk@…:

What's the status of this port, actually?

I've found that the Qt4 version actually fails because it cannot find GST headers anymore.

I could create a separate ticket for now, if needed...

That's #50049.

comment:28 Changed 2 years ago by mkae (Marko Käning)

Cc: michaelld added
Owner: changed from michaelld to mkae
Status: newassigned

I guess I can take over. Assigning it to myself now, please revert, @michaelld, if you feel like it, otherwise I'll take of this in the near future.

comment:29 Changed 2 years ago by michaelld (Michael Dickens)

You're on a roll .. don't let me stop you! I have way too many other things requiring my attention right now; I'm just barely able to keep up with my "usual" MacPorts work ...

comment:30 Changed 2 years ago by mkae (Marko Käning)

Resolution: fixed
Status: assignedclosed

In 47c0c4f/macports-ports:

phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

Squash commit:

commit 5084c0bb0f4edef8ad380910182fad25a5c203f8
Author: Marko Käning <mk@…>
Date: Tue Dec 13 04:51:38 2016 +0100

phonon-backend-gstreamer-qt5: michaelld drops maintainership

commit 848cd25de1d3fa80eab96d6b5aa4d7deb9cb513f
Author: Marko Käning <mk@…>
Date: Tue Dec 13 04:47:21 2016 +0100

phonon-backend-gstreamer(-qt5): master_sites's folder changed for 4.9.0

commit 909946083acb91e66b8d88a489773ba066e6954e
Author: Marko Käning <mk@…>
Date: Tue Dec 13 04:31:20 2016 +0100

phonon-backend-gstreamer: update to 4.9.0

  • avoiding building the X11 renderer has changed => new patch
  • remove unused patches

commit ccaa0e34a4aa2fafc8276a6fb8d86fa8af7398a2
Author: Marko Käning <mk@…>
Date: Tue Dec 13 03:09:55 2016 +0100

phonon-backend-gstreamer: introduce qt5 support

  • add co-maintainership for RJVB

Closes: #46558

comment:31 Changed 2 years ago by mkae (Marko Käning)

In 414fbb18/macports-ports:

phonon-backend-gstreamer(-qt5): update to 4.9.0 and introduce new subport

Squash commit:

commit 5084c0bb0f4edef8ad380910182fad25a5c203f8
Author: Marko Käning <mk@…>
Date: Tue Dec 13 04:51:38 2016 +0100

phonon-backend-gstreamer-qt5: michaelld drops maintainership

commit 848cd25de1d3fa80eab96d6b5aa4d7deb9cb513f
Author: Marko Käning <mk@…>
Date: Tue Dec 13 04:47:21 2016 +0100

phonon-backend-gstreamer(-qt5): master_sites's folder changed for 4.9.0

commit 909946083acb91e66b8d88a489773ba066e6954e
Author: Marko Käning <mk@…>
Date: Tue Dec 13 04:31:20 2016 +0100

phonon-backend-gstreamer: update to 4.9.0

  • avoiding building the X11 renderer has changed => new patch
  • remove unused patches

commit ccaa0e34a4aa2fafc8276a6fb8d86fa8af7398a2
Author: Marko Käning <mk@…>
Date: Tue Dec 13 03:09:55 2016 +0100

phonon-backend-gstreamer: introduce qt5 support

  • add co-maintainership for RJVB

Closes: #46558

Note: See TracTickets for help on using tickets.