Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#48686 closed submission (fixed)

[pugixml][1.6][new]

Reported by: nikkoara@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: Cc: help@…, ryandesign (Ryan Schmidt), krissen
Port: pugixml

Description

Basic Portfile for pugixml.

Attachments (3)

Portfile (1016 bytes) - added by nikkoara@… 4 years ago.
Portfile.2 (994 bytes) - added by nikkoara@… 4 years ago.
Removed revision field.
Portfile.3 (954 bytes) - added by nikkoara@… 4 years ago.
Third take on PugiXML Portfile

Download all attachments as: .zip

Change History (17)

Changed 4 years ago by nikkoara@…

Attachment: Portfile added

comment:1 Changed 4 years ago by ryandesign (Ryan Schmidt)

Thanks.

The github portgroup should be used.

The revision line should be removed.

Last edited 4 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:2 in reply to:  1 ; Changed 4 years ago by nikkoara@…

Replying to ryandesign@…:

The github portgroup should be used.

There is a line there that indicates the github portgroup. If there is something else that you want me to add, could you please be more specific?

The revision line should be removed.

Done. Thanks!

Changed 4 years ago by nikkoara@…

Attachment: Portfile.2 added

Removed revision field.

comment:3 in reply to:  1 Changed 4 years ago by nikkoara@…

Replying to ryandesign@…:

Thanks.

The github portgroup should be used.

The revision line should be removed

Any updates? Thanks.

comment:4 Changed 4 years ago by help@…

Cc: help@… added

Cc Me!

comment:5 Changed 4 years ago by help@…

Portfile.2 works fine for me, please add this port.

comment:6 in reply to:  5 Changed 4 years ago by nikkoara@…

Replying to help@…:

Portfile.2 works fine for me, please add this port.

Guys, I am not sure if you're waiting for me to do something about it. If so, please let me know, explicitly. Otherwise, I am eagerly waiting for this to become part of the official ports. Thanks.

comment:7 Changed 4 years ago by mf2k (Frank Schima)

Some more comments:

  • The distfiles line should be removed because that is the default.
  • An rmd160 checksum should be added.
  • openmaintainer should be added.

comment:8 Changed 4 years ago by mojca (Mojca Miklavec)

The first line is probably a matter of github.setup, right? (I didn't try it.)

I would also suggest adding

cmake.out_of_source yes

as mentioned in the ticket #47197. That is not an obligatory part, but something that would be helpful for the future.

comment:9 in reply to:  2 Changed 4 years ago by ryandesign (Ryan Schmidt)

Replying to nikkoara@…:

Replying to ryandesign@…:

The github portgroup should be used.

There is a line there that indicates the github portgroup. If there is something else that you want me to add, could you please be more specific?

You have included the github portgroup, but are not using it. For instructions on how to use it, read its source code.

comment:10 Changed 4 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

Cc Me!

Changed 4 years ago by nikkoara@…

Attachment: Portfile.3 added

Third take on PugiXML Portfile

comment:11 Changed 4 years ago by nikkoara@…

Thanks for all feed-back. I think I have addressed them all and I have attached the updated Portfile.

comment:12 Changed 4 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Thanks, this looks good now. I made another slight change by swapping the maintainer names. Real persons should be listed before openmaintainer.

Committed in r142578.

comment:13 Changed 4 years ago by ryandesign (Ryan Schmidt)

Removed "universal_variant yes" in r142601 because that is the default.

comment:14 Changed 4 years ago by krissen

Cc: kristian.niemi@… added

Cc Me!

Note: See TracTickets for help on using tickets.