Opened 4 years ago

Closed 4 years ago

#50007 closed defect (fixed)

root5: 5.34.34_1 incompatible with GSL 2

Reported by: andre.david@… Owned by: cjones051073 (Chris Jones)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), mojca (Mojca Miklavec)
Port: root5

Description

I was just updating root5 and it is failing with:

:info:build /usr/bin/clang++ -O2 -m64 -pipe -Wshadow -W -Wall -Woverloaded-virtual -fsigned-char -fno-common -Iinclude -DR__HAVE_CONFIG    -std=c++11 -stdlib=libc++   -pthread -I/opt/local/include  -DUSE_ROOT_ERROR -o math/mathmore/src/GSLRootFinderDeriv.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root5/root5/work/root-5-34-34/math/mathmore/src/GSLRootFinderDeriv.cxx
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root5/root5/work/root-5-34-34/math/mathmore/src/GSLNLSMinimizer.cxx:19:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root5/root5/work/root-5-34-34/math/mathmore/src/GSLMultiFit.h:142:38: error: no member named 'J' in 'gsl_multifit_fdfsolver'
:info:build       gsl_multifit_gradient(fSolver->J, fSolver->f,fVec);
:info:build                             ~~~~~~~  ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root5/root5/work/root-5-34-34/math/mathmore/src/GSLMultiFit.h:153:45: error: no member named 'J' in 'gsl_multifit_fdfsolver'
:info:build       int ret = gsl_multifit_covar(fSolver->J, kEpsrel, fCov);
:info:build                                    ~~~~~~~  ^

This looks too intrinsic to be related to my build flags, etc. Can I provide any further information?

Attachments (1)

root5.diff (4.2 KB) - added by mojca (Mojca Miklavec) 4 years ago.
A patch for GSL for ROOT5

Download all attachments as: .zip

Change History (12)

comment:1 Changed 4 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

The current version of gsl is incompatible with root5 (#49594).
Have you tried installing without the gsl variant?

comment:2 Changed 4 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Cc: mcalhoun@… added

Cc Me!

comment:3 Changed 4 years ago by andre.david@…

I confirm that -gsl did the trick. Anyway, time to move on to root6.

comment:4 Changed 4 years ago by andre.david@…

Looks like root6 is also affected somehow. See #49935.

comment:5 Changed 4 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:6 Changed 4 years ago by mojca (Mojca Miklavec)

Owner: changed from macports-tickets@… to jonesc@…
Version: 2.3.4

comment:7 Changed 4 years ago by mojca (Mojca Miklavec)

Root6 was supposed to be fixed by #50011, I only need to figure out what exactly to commit. And now maybe it makes sense to address the gsl issue in ROOT5 first anyway.

Changed 4 years ago by mojca (Mojca Miklavec)

Attachment: root5.diff added

A patch for GSL for ROOT5

comment:8 Changed 4 years ago by mojca (Mojca Miklavec)

Chris, I'm currently testing the attached patch that reverts r142498. If it proves to be successful and if you agree with it, I'll commit it combined with #50011 to avoid unnecessary revbumps.

Last edited 4 years ago by mojca (Mojca Miklavec) (previous) (diff)

comment:9 Changed 4 years ago by cjones051073 (Chris Jones)

Fine by me ;)

comment:10 Changed 4 years ago by mojca (Mojca Miklavec)

Changes committed in r143637.

comment:11 Changed 4 years ago by mojca (Mojca Miklavec)

Resolution: fixed
Status: newclosed
Summary: root5 5.34.34_1 does not compileroot5: 5.34.34_1 incompatible with GSL 2

This issue should have been fixed. In case you are still experiencing problems, please open a new ticket.

Note: See TracTickets for help on using tickets.