Opened 8 years ago

Closed 8 years ago

#51018 closed submission (fixed)

Portfile for bowtie2

Reported by: gaberoo@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port: bowtie2

Description

Portfile for bowtie2.

Bowtie2 has no dependencies besides XCode.

Attachments (3)

patch-src-Makefile.diff (715 bytes) - added by gaberoo@… 8 years ago.
Same patch as before
Portfile.2 (2.3 KB) - added by gaberoo@… 8 years ago.
Version 2.2.9
Portfile (2.3 KB) - added by gaberoo@… 8 years ago.
Version 2.2.9

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. Some comments:

  • The maintainers line should only include your obfuscated email address, not your name.
  • You should use the github portgroup rather than manually specifying the master_sites and distfiles. You'll need to change the checksums too, since with the github portgroup you'll be fetching a tarball URL, not an archive URL.
  • Since you're disabling the configure phase, you're responsible for ensuring the build is UsingTheRightCompiler and -arch flags and has a functional universal variant.

comment:2 in reply to:  description Changed 8 years ago by gaberoo@…

Hi ryandesign.

Thanks for your comments and sorry for the lack of experience.

I've changed the maintainers line and now use the github portgroup.

Also, I've made a small patch that ensure that the MacPorts compiler gets used. I'm not 100% sure about the best practices for dealing with universal variants when the source doesn't use a configure script. But for now, I've disabled the universal variant. Is that acceptable?

comment:3 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:4 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Is there any reason to not just update the current bowtie port instead of adding bowtie2?

comment:5 Changed 8 years ago by gaberoo@…

Bowtie 1 and 2 are two different releases:

http://bowtie-bio.sourceforge.net/index.shtml

http://bowtie-bio.sourceforge.net/bowtie2/index.shtml

That was my logic in adding bowtie2. Perhaps the bowtie port should be updated to the newest version of bowtie 1 though.

comment:6 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

OK, is there any reason to not use 2.2.9?

Changed 8 years ago by gaberoo@…

Attachment: patch-src-Makefile.diff added

Same patch as before

comment:7 Changed 8 years ago by gaberoo@…

No reason... here is the new portfile

Changed 8 years ago by gaberoo@…

Attachment: Portfile.2 added

Version 2.2.9

Changed 8 years ago by gaberoo@…

Attachment: Portfile added

Version 2.2.9

comment:8 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.