ucommon-7.0.0 fails to build on Mac OS X 10.5 Leopard: error: 'AI_NUMERICSERV' was not declared in this scope

[linuxjunkie999]

see log file for error.

[linuxjunkie999]

build log for ucommon

[mf2k (Frank Schima)]

In the future, please use WikiFormatting.

[kencu (Ken)]

1113	:info:build libtool: compile:  ccache /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I.. -I/opt/local/include -I../inc -Wno-long-long -pthread -fno-check-new -finline -fvisibility=hidden -I/opt/local/include -pipe -Os -arch ppc -MT socket.lo -MD -MP -MF .deps/socket.Tpo -c socket.cpp  -fno-common -DPIC -o .libs/socket.o
1114	:info:build libtool: compile:  ccache /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I.. -I/opt/local/include -I../inc -Wno-long-long -pthread -fno-check-new -finline -fvisibility=hidden -I/opt/local/include -pipe -Os -arch ppc -MT memory.lo -MD -MP -MF .deps/memory.Tpo -c memory.cpp -o memory.o >/dev/null 2>&1
1115	:info:build depbase=`echo access.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
1116	:info:build     /bin/sh ../libtool  --tag=CXX   --mode=compile ccache /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I..   -I/opt/local/include -I../inc -Wno-long-long -pthread -fno-check-new -finline -fvisibility=hidden -I/opt/local/include -pipe -Os -arch ppc -MT access.lo -MD -MP -MF $depbase.Tpo -c -o access.lo access.cpp &&\
1117	:info:build     mv -f $depbase.Tpo $depbase.Plo
1118	:info:build libtool: compile:  ccache /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I.. -I/opt/local/include -I../inc -Wno-long-long -pthread -fno-check-new -finline -fvisibility=hidden -I/opt/local/include -pipe -Os -arch ppc -MT access.lo -MD -MP -MF .deps/access.Tpo -c access.cpp  -fno-common -DPIC -o .libs/access.o
1119	:info:build socket.cpp: In member function 'bool ucommon::Socket::address::insert(const sockaddr*)':
1120	:info:build socket.cpp:1272: error: 'AI_NUMERICSERV' was not declared in this scope

[kencu (Ken)]

we have these examples of fixes from other ports:

net/kerberos5/Portfile
51:# AI_NUMERICSERV not available for OS X < 10.6

net/kerberos5/files/patch-src-lib-apputils-net-server.c.diff
7:+/* AI_NUMERICSERV as a value for the `ai_flags' member
23:+#ifndef AI_NUMERICSERV
24:+#define AI_NUMERICSERV 0

www/nghttp2/files/src-shrpx_config.diff
16:+#  ifndef AI_NUMERICSERV
17:+#   define AI_NUMERICSERV 0

[kencu (Ken)]

I have enhanced the legacysupport port to add this missing define, however, even though (with that PG added) ucommon now builds on Leopard, many tests fail.

/usr/bin/make  check-TESTS
PASS: ucommonLinked
PASS: ucommonSocket
../autoconf/test-driver: line 107: 34808 Abort trap              "$@" > $log_file 2>&1
FAIL: ucommonStrings
PASS: ucommonThreads
../autoconf/test-driver: line 107: 34847 Abort trap              "$@" > $log_file 2>&1
FAIL: ucommonMemory
PASS: ucommonKeydata
PASS: ucommonStream
PASS: ucommonUnicode
../autoconf/test-driver: line 107: 34925 Abort trap              "$@" > $log_file 2>&1
FAIL: ucommonDatetime
PASS: ucommonShell
../autoconf/test-driver: line 107: 34963 Abort trap              "$@" > $log_file 2>&1
FAIL: ucommonDigest
PASS: ucommonCipher
make[4]: Nothing to be done for `all'.
============================================================================
Testsuite summary for ucommon 7.0.0
============================================================================
# TOTAL: 12
# PASS:  8
# SKIP:  0
# XFAIL: 0
# FAIL:  4
# XPASS: 0
# ERROR: 0
============================================================================
See test/test-suite.log

I don't know if this is a 32bit thing, or a Leopard thing, or whether there are multiple issues at play.

It's a bit hard to commit this fix but have the ucommon port so clearly broken on these older systems. Perhaps better to leave it non-building until this can be sorted out properly?

[ryandesign (Ryan Carsten Schmidt)]

Can you attach a crash log?

[kencu (Ken)]

it looks like a 32 bit thing. these errors are on 32 bit SL