ifeffit @1.2.13: error: implicit declaration of function 'ioctl' is invalid in C99

[NozomuIshiguro (Nozomu Ishiguro)]

From the log file (as follows):

===  ifeffit 1.2.12 Configuration Results:
===  linking to PGPLOT with: -L/opt/local/lib -lpgplot -lpng -lX11
===
===  could not find TERMCAP Libraries : 'make' will fail.
===
===  Please set TERMCAP_LIB in src/cmdline/Makefile or use the
===  --termcap-link argument before running make
--->  Building ifeffit
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/ifeffit-1.2.13" && /usr/bin/make -j8 -w all 
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/newville-ifeffit-83b3455'

  make done.  If there were no errors, type 'make install'
/Library/Developer/CommandLineTools/usr/bin/make  all-recursive
make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/newville-ifeffit-83b3455'
Making all in readline
make[2]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/newville-ifeffit-83b3455/readline'
rm -f readline.o
rm -f vi_mode.o
rm -f funmap.o
rm -f keymaps.o
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 vi_mode.c
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 readline.c
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 funmap.c
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 keymaps.c
rm -f parens.o
rm -f search.o
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 parens.c
rm -f rltty.o
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 search.c
rm -f complete.o
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 rltty.c
/usr/bin/clang -c -DHAVE_CONFIG_H  -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -I. -I. -DRL_LIBRARY_VERSION='"5.0"' -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk -arch x86_64 complete.c
rltty.c:150:7: error: implicit declaration of function 'ioctl' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  if (ioctl (tty, TIOCGWINSZ, &w) == 0)
      ^
rltty.c:729:3: error: implicit declaration of function 'ioctl' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  ioctl (fildes, TIOCSTART, 0);
  ^
rltty.c:763:3: error: implicit declaration of function 'ioctl' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  ioctl (fildes, TIOCSTOP, 0);
  ^
3 errors generated.
make[2]: *** [rltty.o] Error 1
make[2]: *** Waiting for unfinished jobs....
complete.c:868:23: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
      while (rl_point = _rl_find_prev_mbchar (rl_line_buffer, rl_point, MB_FIND_ANY))
             ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
complete.c:868:23: note: place parentheses around the assignment to silence this warning
      while (rl_point = _rl_find_prev_mbchar (rl_line_buffer, rl_point, MB_FIND_ANY))
                      ^
             (                                                                      )
complete.c:868:23: note: use '==' to turn this assignment into an equality comparison
      while (rl_point = _rl_find_prev_mbchar (rl_line_buffer, rl_point, MB_FIND_ANY))
                      ^
                      ==
complete.c:1154:51: warning: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
              dtext = (*rl_filename_dequoting_function) (text, rl_completion_quote_character);
                                                         ^~~~
complete.c:1801:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
  while (string = (*entry_function) (text, matches))
         ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
complete.c:1801:17: note: place parentheses around the assignment to silence this warning
  while (string = (*entry_function) (text, matches))
                ^
         (                                         )
complete.c:1801:17: note: use '==' to turn this assignment into an equality comparison
  while (string = (*entry_function) (text, matches))
                ^
                ==
complete.c:1851:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
  while (entry = getpwent ())
         ~~~~~~^~~~~~~~~~~~~
complete.c:1851:16: note: place parentheses around the assignment to silence this warning
  while (entry = getpwent ())
               ^
         (                  )
complete.c:1851:16: note: use '==' to turn this assignment into an equality comparison
  while (entry = getpwent ())
               ^
               ==
4 warnings generated.
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/newville-ifeffit-83b3455/readline'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/newville-ifeffit-83b3455'
make: *** [all-recursive-am] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/newville-ifeffit-83b3455'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/work/ifeffit-1.2.13" && /usr/bin/make -j8 -w all 
Exit code: 2
Error: Failed to build ifeffit: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_ifeffit/ifeffit/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets to report a bug.
Error: Processing of port ifeffit failed

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #63246.

[joefowler (Joe Fowler)]

Fixed by ​https://github.com/macports/macports-ports/pull/12803

[ryandesign (Ryan Carsten Schmidt)]

[6314f8b41f7c3f85e25c612ecec175c116f1a341/macports-ports]