Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#63404 closed defect (fixed)

openssl @1.1.1l fails to build on older OS versions

Reported by: tehcog (tehcog) Owned by: ci42
Priority: Normal Milestone:
Component: ports Version: 2.7.1
Keywords: Cc: larryv (Lawrence Velázquez), neverpanic (Clemens Lang), evanmiller (Evan Miller)
Port: openssl

Description

:info:build crypto/rand/rand_unix.c:38:11: fatal error: 'CommonCrypto/CommonRandom.h' file not found
:info:build # include <CommonCrypto/CommonRandom.h>
:info:build           ^
:info:build 1 error generated.
:info:build make[1]: *** [crypto/rand/rand_unix.o] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_openssl/openssl/work/openssl-1.1.1l'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_openssl/openssl/work/openssl-1.1.1l'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_openssl/openssl/work/openssl-1.1.1l" && /usr/bin/make -j1 -w all 
:info:build Exit code: 2
:error:build Failed to build openssl: command execution failed

Attachments (2)

main.log (325.2 KB) - added by tehcog (tehcog) 13 months ago.
main.log
main.2.log (325.9 KB) - added by squiggledid 13 months ago.
main.log from MacOS 10.13.6

Download all attachments as: .zip

Change History (13)

Changed 13 months ago by tehcog (tehcog)

Attachment: main.log added

main.log

comment:1 Changed 13 months ago by tehcog (tehcog)

Please see attached main.log

comment:2 Changed 13 months ago by SiliconExarch

Also failing on Leopard PPC with the same error, probably safe to say at least 10.4-10.9 are affected.

comment:3 Changed 13 months ago by squiggledid

Also failing on 10.13.6. The error is different though:

:info:build /usr/include/CommonCrypto/CommonRandom.h:35:9: error: unknown type name 'CCCryptorStatus'

main.log will be attached.

Changed 13 months ago by squiggledid

Attachment: main.2.log added

main.log from MacOS 10.13.6

comment:4 Changed 13 months ago by jmroot (Joshua Root)

Owner: set to ci42
Status: newassigned
Summary: openssl @1.1.1l fails to build on mavericksopenssl @1.1.1l fails to build on older OS versions

Seems to have failed to build on everything older than 10.14.

comment:5 Changed 13 months ago by kencu (Ken)

This commit:

https://github.com/openssl/openssl/commit/b58ac9f1e3f828b5c65c9edd5bb86603a4886a26#diff-dba8c3f61f549f95824cacc4d356df3e33e7c6db5038f8a6e5c0d2e2ad46a45a

But how exactly did it work before? More to discover...

Ed: looks like it just fell through to the default. There's a trivial test to add for the working versions to fix this I think.

Last edited 13 months ago by kencu (Ken) (previous) (diff)

comment:6 Changed 13 months ago by kencu (Ken)

comment:8 Changed 13 months ago by evanmiller (Evan Miller)

Cc: evanmiller added

comment:9 in reply to:  7 Changed 13 months ago by Gcenx

Replying to kencu:

one person's proposed patch:

https://github.com/devnexen/openssl/commit/ba019aa84474bb5190689d85948b8c01c3230817

Applied that locally and it does indeed resolve the build issues.

comment:10 Changed 13 months ago by reneeotten (Renee Otten)

Resolution: fixed
Status: assignedclosed

Fixed in this commit

comment:11 Changed 13 months ago by kencu (Ken)

good enough. We'll need to tweak that for Tiger.

Note: See TracTickets for help on using tickets.