Opened 5 weeks ago

Closed 2 days ago

#66111 closed enhancement (worksforme)

libedit @20221009-3.1 uses an old configure argument

Reported by: ballapete (Peter "Pete" Dyballa) Owned by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)
Priority: Normal Milestone:
Component: ports Version: 2.8.0
Keywords: monterey, leopard Cc: judaew (Vadym-Valdis Yudaiev)
Port: libedit

Description

checking if you want wide-character code... no
configure: WARNING: --enable-widec is deprecated, wide-character/UTF-8 is always enabled

These two do not really match each others…

Change History (5)

comment:1 Changed 5 weeks ago by ryandesign (Ryan Schmidt)

Cc: judaew added; mcalhoun@… judaew@… removed
Owner: set to MarcusCalhoun-Lopez
Status: newassigned

comment:2 Changed 5 weeks ago by judaew (Vadym-Valdis Yudaiev)

It looks like a stub to me. I think the developer wants to say with this AC_MSG_WARN that the --enable-widec option is deprecated and this support is enabled automatically.

dnl
dnl deprecate option --enable-widec to turn on use of wide-character support
dnl
AC_DEFUN([EL_DEPRECATE_WIDEC],
[
   AC_MSG_CHECKING(if you want wide-character code)
   AC_ARG_ENABLE(widec,
      [  --enable-widec          deprecated, wide-character/UTF-8 is always enabled],
      [with_widec=$enableval],
      [with_widec=no])
   AC_MSG_RESULT($with_widec)
   AC_MSG_WARN([--enable-widec is deprecated, wide-character/UTF-8 is always enabled])
])

comment:3 Changed 5 weeks ago by judaew (Vadym-Valdis Yudaiev)

The --enable-widec option is not used in Portfile for building. I wrote a test C program that uses libedit and wide-character/UTF-8 and it worked correctly. It's LGTM.

comment:4 Changed 5 weeks ago by judaew (Vadym-Valdis Yudaiev)

libedit as of 3.11 decided to force Unicode support by changing the callback signature of the getcfn (el_rfunc_t) callback from a char * to a wchar_t *.

Last edited 5 weeks ago by judaew (Vadym-Valdis Yudaiev) (previous) (diff)

comment:5 Changed 2 days ago by kencu (Ken)

Resolution: worksforme
Status: assignedclosed

looks like nothing to do here.

Note: See TracTickets for help on using tickets.