Opened 14 months ago

Closed 14 months ago

#67091 closed defect (fixed)

git-devel: failure to build on 10.6 and 10.7 due to "undeclared identifier 'REG_ENHANCED'"

Reported by: herbygillot (Herby Gillot) Owned by: herbygillot (Herby Gillot)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: git-devel

Description

Development version of git at version 2.40.0-rc2 is failing to build on macOS 10.6 and 10.7: 

/usr/bin/clang -o compat/fsmonitor/fsm-settings-darwin.o -c -MF compat/fsmonitor/.depend/fsm-settings-darwin.o.d -MQ compat/fsmonitor/fsm-settings-darwin.o -MMD -MP    -Os -std=gnu99 -arch x86_64 -I. -DPRECOMPOSE_UNICODE -DPROTECT_HFS_DEFAULT=1 -DGIT_HOST_CPU="\"x86_64\"" -DUSE_LIBPCRE2 -I/opt/local/include -I/opt/local/include -DUSE_CURL_FOR_IMAP_SEND -DNO_OPENSSL -I/opt/local/include -DUSE_ST_TIMESPEC -DSUPPORTS_SIMPLE_IPC -DSHA1_DC -DSHA1DC_NO_STANDARD_INCLUDES -DSHA1DC_INIT_SAFE_HASH_DEFAULT=0 -DSHA1DC_CUSTOM_INCLUDE_SHA1_C="\"cache.h\"" -DSHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C="\"git-compat-util.h\"" -DSHA256_BLK  -DHAVE_DEV_TTY -DHAVE_BSD_SYSCTL -DHAVE_GETDELIM -DHAVE_ARC4RANDOM -DHAVE_NS_GET_EXECUTABLE_PATH  -DAPPLE_COMMON_CRYPTO -DFREAD_READS_DIRECTORIES -DNO_MEMMEM -DUSE_ENHANCED_BASIC_REGULAR_EXPRESSIONS -DHAVE_FSMONITOR_OS_SETTINGS -DSHELL_PATH='"/bin/sh"'  compat/fsmonitor/fsm-settings-darwin.c
compat/regcomp_enhanced.c:7:13: error: use of undeclared identifier 'REG_ENHANCED'
                cflags |= REG_ENHANCED;
                          ^
/usr/bin/clang -o compat/fsmonitor/fsm-path-utils-darwin.o -c -MF compat/fsmonitor/.depend/fsm-path-utils-darwin.o.d -MQ compat/fsmonitor/fsm-path-utils-darwin.o -MMD -MP    -Os -std=gnu99 -arch x86_64 -I. -DPRECOMPOSE_UNICODE -DPROTECT_HFS_DEFAULT=1 -DGIT_HOST_CPU="\"x86_64\"" -DUSE_LIBPCRE2 -I/opt/local/include -I/opt/local/include -DUSE_CURL_FOR_IMAP_SEND -DNO_OPENSSL -I/opt/local/include -DUSE_ST_TIMESPEC -DSUPPORTS_SIMPLE_IPC -DSHA1_DC -DSHA1DC_NO_STANDARD_INCLUDES -DSHA1DC_INIT_SAFE_HASH_DEFAULT=0 -DSHA1DC_CUSTOM_INCLUDE_SHA1_C="\"cache.h\"" -DSHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C="\"git-compat-util.h\"" -DSHA256_BLK  -DHAVE_DEV_TTY -DHAVE_BSD_SYSCTL -DHAVE_GETDELIM -DHAVE_ARC4RANDOM -DHAVE_NS_GET_EXECUTABLE_PATH  -DAPPLE_COMMON_CRYPTO -DFREAD_READS_DIRECTORIES -DNO_MEMMEM -DUSE_ENHANCED_BASIC_REGULAR_EXPRESSIONS -DHAVE_FSMONITOR_OS_SETTINGS -DSHELL_PATH='"/bin/sh"'  compat/fsmonitor/fsm-path-utils-darwin.c
1 error generated.
make: *** [compat/regcomp_enhanced.o] Error 1
make: *** Waiting for unfinished jobs....

Change History (5)

comment:2 Changed 14 months ago by herbygillot (Herby Gillot)

In 973db6508ec3f89c627a6441a54a54e04f11cbbd/macports-ports (master):

git-devel: disable USE_ENHANCED_BASIC_REGULAR_EXPRESSIONS for < macOS 10.8

See: #67091

comment:3 Changed 14 months ago by jmroot (Joshua Root)

The check for USE_ENHANCED_BASIC_REGULAR_EXPRESSIONS is an ifdef, so defining it to something else won't help. I think you want to patch config.mak.uname so it doesn't define it on the relevant OS versions.

comment:4 Changed 14 months ago by herbygillot (Herby Gillot)

In 62851305119bd3fea2eefa451b49a975232b4ea6/macports-ports (master):

git-devel: disable USE_ENHANCED_BASIC_REGULAR_EXPRESSIONS for < macOS 10.8

See: #67091

comment:5 Changed 14 months ago by herbygillot (Herby Gillot)

Resolution: → fixed
Status: assigned → closed

Thanks @jmroot, it looks resolved now:

Note: See TracTickets for help on using tickets.