mpv @0.35.1, mpv-legacy: C11 atomics are required; you may need a newer compiler

[ryandesign (Ryan Carsten Schmidt)]

​https://build.macports.org/builders/ports-10.9_x86_64-builder/builds/224889/steps/install-port/logs/stdio
​https://build.macports.org/builders/ports-10.8_x86_64-builder/builds/127726/steps/install-port/logs/stdio

Checking for C11 stdatomic.h                                              : no 
C11 atomics are required; you may need a newer compiler

[ryandesign (Ryan Carsten Schmidt)]

The Portfile already says:

# C11 atomics is mandatory from version 0.33.0
compiler.c_standard 2011

but C11 atomics are not guaranteed by compiler.c_standard 2011. You'll need to add code like 08560e52b1246a5f303ebf5ceb5c5bfdc508c6f1/macports-ports.

[i0ntempest]

In 08e684cf1d3384dfb8b8feaf4b3d0bf31176f6a7/macports-ports (master):

mpv: blacklist clang < 700 for stdatomic

Closes: #67166

[i0ntempest]

Did not work apparently: ​https://build.macports.org/builders/ports-10.9_x86_64-builder/builds/225138/steps/install-port/logs/stdio

[jmroot (Joshua Root)]

There was already a blacklist in place for *gcc* cc macports-*, so that leaves no possible compilers on the affected systems.

Warning: All compilers are either blacklisted or unavailable; defaulting to first fallback option

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #67218.

[kencu (Ken)]

If you delete this blacklisting out of the Portfile:

        # Force clang compiler as installed by Xcode's CLT's... hopefully.
        compiler.blacklist-append   *gcc* cc macports-*

the port builds through on 10.9 without any hassles:

$ port -v installed mpv
The following ports are currently installed:
  mpv @0.35.1_3+audiocd+bluray+bundle+dvd+libarchive+network+opengl+osd+python311+rubberband+x11 (active) requested_variants='' platform='darwin 13' archs='x86_64' date='2023-06-05T13:23:16-0700'

and runs without crashing.

[kencu (Ken)]

all the fancy stuff about libarclite mentioned in the Portfile for 10.7 support and forcing Xcode needs to be re-thought and probably all removed.

[kencu (Ken)]

I just built mpv on 10.7 as well, deleting the above block.

It builds with no issues, using clang-15.

I recall working though some of this arc stuff on 10.7 with Josh a year ago or so here #66188

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #69260 for mpv-legacy.

[barracuda156]

Replying to kencu:

all the fancy stuff about libarclite mentioned in the Portfile for 10.7 support and forcing Xcode needs to be re-thought and probably all removed.

I think I just restored portfile as it was before. I did not test it on 10.7 and have no set-up. Should I remove that chunk? For Intel I can just follow your advice here. For PPC it is likely still broken, I will deal with that once my Leopard set-up is back to life, since it must be tested there as well.

[mrkapqa]

this trick

# Force clang compiler as installed by Xcode's CLT's... hopefully.
        compiler.blacklist-append   *gcc* cc macports-*

as provided by kencu would function with mpv-legacy for mavericks, but not mountain lion< not needed for yosemite as mpv-legacy would build through, like on sierra.

however, there would be no audio playback on the computer from the mpv-legacy via terminal, from mavericks through sierra, it state like

Could not open/initialize audio device -> no sound.

so probably there is some error.