libsdl2: builds fail for 10.7/10.8: error: no visible @interface for 'NSAlert' declares the selector 'beginSheetModalForWindow:completionHandler

[mascguy (Christopher Nielsen)]

Details (absolute paths truncated for readability):

libsdl2/work/SDL2-2.28.0/src/video/cocoa/SDL_cocoamessagebox.m:60:43: error: expected ')'
                      completionHandler:^(NSModalResponse returnCode) {
                                          ^
libsdl2/work/SDL2-2.28.0/src/video/cocoa/SDL_cocoamessagebox.m:60:42: note: to match this '('
                      completionHandler:^(NSModalResponse returnCode) {
                                         ^
libsdl2/work/SDL2-2.28.0/src/video/cocoa/SDL_cocoamessagebox.m:60:41: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
                      completionHandler:^(NSModalResponse returnCode) {
                                        ^
libsdl2/work/SDL2-2.28.0/src/video/cocoa/SDL_cocoamessagebox.m:61:50: error: use of undeclared identifier 'returnCode'
                        [NSApp stopModalWithCode:returnCode];
                                                 ^
libsdl2/work/SDL2-2.28.0/src/video/cocoa/SDL_cocoamessagebox.m:59:10: error: no visible @interface for 'NSAlert' declares the selector 'beginSheetModalForWindow:completionHandler:'
        [alert beginSheetModalForWindow:nswindow
         ^
2 warnings and 3 errors generated.
make: *** [build/SDL_cocoamessagebox.lo] Error 1

​https://ports.macports.org/port/libsdl2/details/

[kencu (Ken)]

“ Please note that building SDL requires at least Xcode 6 and the 10.9 SDK. PowerPC support for macOS has been officially dropped as of SDL 2.0.2. 32-bit Intel and macOS 10.8 runtime support has been officially dropped as of SDL 2.24.0.”

[mascguy (Christopher Nielsen)]

So it sounds like we should pin 10.7/10.8 to the previous version (2.26.5)...?

[jmroot (Joshua Root)]

It was working fine as of last release though. You could certainly ask upstream if it was really intentional to drop OS compatibility in the last release before maintenance mode. Better yet if you provide a patch to fix it; they've accepted fixes for these older OS versions from me before, and I don't think there were all that many changes to the macOS specific code in this release.

[aeiouaeiouaeiouaeiouaeiouaeiou]

​https://github.com/libsdl-org/SDL/commit/dfc56cfc0eae8e09d9da401483655d4e171b6080

Can you try to build with this commit reversion?

[mascguy (Christopher Nielsen)]

Replying to aeiouaeiouaeiouaeiouaeiouaeiou:

​https://github.com/libsdl-org/SDL/commit/dfc56cfc0eae8e09d9da401483655d4e171b6080

Can you try to build with this commit reversion?

Yep, that fixes it. Thanks!

PR created:

​PR 19207 - libsdl2: patch to revert upstream fix for sdl issue 6948

[Christopher Nielsen <mascguy@…>]

In 5a4c116d3f21a3fe2a6be7fc4aa8195dd99d21ec/macports-ports (master):

libsdl2: patch to revert upstream fix for sdl issue 6948

• Fixes builds for 10.7/10.8

Closes: #67666

[mascguy (Christopher Nielsen)]

Reopening ticket, as it would be preferable to provide a patch to upstream with macOS version checks re-added.