R-s2 @1.1.4: error: use of undeclared identifier 'MAP_ANONYMOUS'

[ryandesign (Ryan Schmidt)]

R-s2 @1.1.4 failed to build on the 10.7–10.10 buildbot workers two months ago. Logs have expired so I've scheduled new builds. There is a backlog of builds so it may take a day for it to get to those builds.

[barracuda156]

Replying to ryandesign:

R-s2 @1.1.4 failed to build on the 10.7–10.10 buildbot workers two months ago. Logs have expired so I've scheduled new builds. There is a backlog of builds so it may take a day for it to get to those builds.

But it was building on 10.6 Intel? I think all those should be using the same Clang, after we blacklisted Xcode ones in R PG, so no idea, honestly, why it would fail.

For the record, s2 is a tricky thing: I failed to fix it on Rosetta, for example, though it builds now on PPC natively. There is a discussion with upstream: ​https://github.com/google/s2geometry/issues/315

[ryandesign (Ryan Schmidt)]

Replying to barracuda156:

Replying to ryandesign:

R-s2 @1.1.4 failed to build on the 10.7–10.10 buildbot workers two months ago. Logs have expired so I've scheduled new builds. There is a backlog of builds so it may take a day for it to get to those builds.

But it was building on 10.6 Intel?

Yes. The 10.7–10.10 builds ran and all failed due to:

absl/debugging/internal/examine_stack.cc:58:34: error: use of undeclared identifier 'MAP_ANONYMOUS'
                   MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
                                 ^
1 error generated.

so that's a simple fix of:

#ifndef MAP_ANONYMOUS
#define MAP_ANONYMOUS MAP_ANON
#endif

Or the legacysupport portgroup can be included which includes that fix.

I'm not sure why the build succeeded on 10.6.

[ryandesign (Ryan Schmidt)]

​https://github.com/r-spatial/s2/issues/245

[ryandesign (Ryan Schmidt)]

I'm testing a fix now and will commit shortly.

[ryandesign (Ryan Schmidt)]

In 6102b5d9c70d7c21c9d20f79ce9ff65fc2b77772/macports-ports (master):

R-s2: Define MAP_ANONYMOUS for OS X <= 10.10

Closes: #67784

[barracuda156]

Replying to ryandesign:

I'm testing a fix now and will commit shortly.

Thank you! Great!

[ryandesign (Ryan Schmidt)]

It should look familiar to you! The patch is for R-s2's bundled copy of abseil, and you wrote a similar patch for abseil in ​https://github.com/macports/macports-ports/pull/15471.

[barracuda156]

Replying to ryandesign:

It should look familiar to you! The patch is for R-s2's bundled copy of abseil, and you wrote a similar patch for abseil in ​https://github.com/macports/macports-ports/pull/15471.

Yes indeed.