sbcl @2.3.6: patch failure on Big Sur

[ryandesign (Ryan Carsten Schmidt)]

sbcl fails to patch on Big Sur only:

​https://build.macports.org/builders/ports-11_arm64-builder/builds/96914/steps/install-port/logs/stdio

Executing:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_sbcl/sbcl/work/sbcl-2.3.6" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/lang/sbcl/files/0004-arm-Darwin-disable-futex-on-BigSur.patch'
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_sbcl/sbcl/work/sbcl-2.3.6" && /usr/bin/patch -p0 < '/opt/bblocal/var/buildworker/ports/build/ports/lang/sbcl/files/0004-arm-Darwin-disable-futex-on-BigSur.patch'
patching file make-config.sh
patching file src/cold/shared.lisp
Hunk #1 FAILED at 291.
1 out of 1 hunk FAILED -- saving rejects to file src/cold/shared.lisp.rej

Whatever bug this patch is fixing really only occurs on Big Sur? Not on earlier nor later versions of macOS? Is there an upstream bug URL for this problem?

[tomio-arisaka (Tomio Arisaka)]

The FUTEX issue is fixed.
See ​https://sourceforge.net/p/sbcl/sbcl/ci/22562f65ebd93be38586cd823ce758335bc288b3/

[catap (Kirill A. Korinsky)]

This is forgotten to be removed patch from the last update. I'll make a PR in couple of hours.

[catap (Kirill A. Korinsky)]

Ryan, the issue that futex aren't work as expected on BigSur and SBCL enforced it on any macOS on ARM. The old patch was required for 2.3.5 where it was introduced. Anyway, since 2.3.6 it doesn't an issue and upstream fixed it the right way.

See: ​https://github.com/macports/macports-ports/pull/19540

[catap (Kirill A. Korinsky)]

In 2823cd3bd26eb2c3c37cf248e0210bb3714ae135/macports-ports (master):

sbcl: removed unrequired patch for BigSur

This patch hasn't required for 2.3.6 anymore.

Closes: #67785