Opened 14 months ago

Closed 13 months ago

Last modified 13 months ago

#52608 closed update (fixed)

updates for snappy & leveldb

Reported by: RJVB (René Bertin) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: snappy leveldb

Description

Please find attached the latest updates for port:snappy and port:leveldb . I'm not particularly interested in becoming their maintainer, though.

Attachments (2)

snappy.diff (1.2 KB) - added by RJVB (René Bertin) 14 months ago.
leveldb.diff (2.3 KB) - added by RJVB (René Bertin) 14 months ago.

Download all attachments as: .zip

Change History (15)

Changed 14 months ago by RJVB (René Bertin)

Changed 14 months ago by RJVB (René Bertin)

comment:1 Changed 14 months ago by mf2k (Frank Schima)

  • Port changed from snappy, leveldb to snappy leveldb

comment:2 Changed 14 months ago by ryandesign (Ryan Schmidt)

  • Owner changed from macports-tickets@… to ryandesign@…
  • Status changed from new to assigned

Thanks.

comment:3 follow-up: Changed 14 months ago by ryandesign (Ryan Schmidt)

Committed the snappy update in r153867 with these changes:

  • removed name snappy line and commented-out #version 1.1.1 line
  • replaced tabs in changed lines with spaces
  • used release download, which avoids the need to run autoreconf

comment:4 in reply to: ↑ 3 Changed 14 months ago by RJVB (René Bertin)

Replying to ryandesign@…:

  • used release download, which avoids the need to run autoreconf

Hrmf, I thought I'd obtained that by specifying a release tag and now using fetch.type=git ...

Running autoreconf isn't a big deal for a single build if you already have the tools installed, but it's true that it quickly grows old (and perceptually ever slower) if you have have to rerun the configure step repeatedly.

comment:5 follow-up: Changed 13 months ago by ryandesign (Ryan Schmidt)

  • Resolution set to fixed
  • Status changed from assigned to closed

Committed the leveldb update in r153953 with these changes:

  • did not add use_parallel_build yes line because that's been the default for many years
  • removed comment-out # build.args-append libmemenv.a line; looks like libmemenv.a gets built by default now
  • set CFLAGS correctly, so that not just C++ code but also C code gets built for the correct arch (otherwise the universal variant failed)
  • removed the existing lines relating to changing the MacPorts default -Os optimization flag to -O2 because no justification was given for making that change in r140702
  • did not apply your change that installs the libleveldb.dylib files using /usr/bin/install instead of /bin/cp, because doing so causes three separate copies of the library to be installed, rather than one copy and two symlinks which is what we want
  • added patch to fix library install_name. This will require all ports linking with libleveldb.dylib to be revbumped.
Last edited 13 months ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:6 follow-up: Changed 13 months ago by RJVB (René Bertin)

dang, I didn't notice the weird, linuxy library names...

I've done this a bit between other things, but I did wonder why the port doesn't simply use a hand-written destroot rather than generate an install makefile and let that be executed...

comment:7 in reply to: ↑ 6 Changed 13 months ago by ryandesign (Ryan Schmidt)

Replying to rjvbertin@…:

I did wonder why the port doesn't simply use a hand-written destroot rather than generate an install makefile and let that be executed...

That's explained in the Portfile:

# muniversal build requires Makefile

comment:8 Changed 13 months ago by RJVB (René Bertin)

Oh, right, yes. Because muniversal also rolls its own destroot?

comment:9 Changed 13 months ago by ryandesign (Ryan Schmidt)

Yes.

comment:10 in reply to: ↑ 5 ; follow-up: Changed 13 months ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

This will require all ports linking with libleveldb.dylib to be revbumped.

Fixed caffe in r153955. The only other one is qt5-qtwebkit, which is still building.

comment:11 in reply to: ↑ 10 Changed 13 months ago by ryandesign (Ryan Schmidt)

Fixed qt5-qtwebkit in r153957.

comment:12 Changed 13 months ago by RJVB (René Bertin)

I'm not getting the patch file from svn, did you forget to commit it?

comment:13 Changed 13 months ago by ryandesign (Ryan Schmidt)

Yes; see #52631. Fixed in r153991.

Note: See TracTickets for help on using tickets.