Opened 6 years ago

Last modified 6 years ago

#52741 reopened defect

cpuid upgrade, should make it build again

Reported by: RJVB (René Bertin) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: mojca (Mojca Miklavec)
Port: cpuid

Description (last modified by mojca (Mojca Miklavec))

The recent automatic(?)revision of port cpuid in r154381 didn't take the changes into account that I described in the "ports should use perl 5.24" ticket but couldn't apply because I don't have commit access.

cpuid doesn't in practice depend on perl5 anymore (and probably since before it was committed).

The attached patch drops the dependency and bumps the version.

Attachments (2)

cpuid.diff (1.5 KB) - added by RJVB (René Bertin) 6 years ago.
patch-makefile.diff (1.6 KB) - added by RJVB (René Bertin) 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by RJVB (René Bertin)

Attachment: cpuid.diff added

comment:1 Changed 6 years ago by mojca (Mojca Miklavec)

Description: modified (diff)
Resolution: fixed
Status: newclosed

I'm sorry. I saw your comment long time ago, but it slipped me when I was going through the final hunt for any leftovers of perl5.22 and your request to remove dependency made more sense than to rename them anyway.

Thanks, the changes committed in r154436.

comment:2 Changed 6 years ago by RJVB (René Bertin)

Resolution: fixed
Status: closedreopened

Well, apparently something still isn't right on 10.6, 32bit :

ld: absolute addressing (perhaps -mdynamic-no-pic) used in _create_description from cache.o not allowed in slidable image. Use '-read_only_relocs suppress' to enable text relocs

I have no idea where the -fno-PIC options come from I see in the log, but the GNUMakefile does specify -mdynamic-no-pic on OS X. I'm not on a Mac right now so cannot test if that option is required for normal operation (in 64bit). I'll attach an updated patchfile which implements the linker's suggestion to use -read_only_relocs suppress. IIRC that worked for me before in other similar situations, and is safe to use indiscriminately.

Changed 6 years ago by RJVB (René Bertin)

Attachment: patch-makefile.diff added

comment:3 Changed 6 years ago by mojca (Mojca Miklavec)

Whenever the patch is ready and tested, please tell me.

I'm uncomfortable testing if you patch works as expected without having the slightest clue what the software does.

comment:4 Changed 6 years ago by RJVB (René Bertin)

Well, the best I can do is a universal build on 10.9, or try without the dynamic_no_pic option under 64bit to see if it's even necessary.

The software just prints out a list of what the cpu it runs on supports, a more human-readable version of cat /proc/cpuinfo on Linux.

Note: See TracTickets for help on using tickets.