#53947 closed update (fixed)
ansifilter: update to 2.4
| Reported by: | tessus (Helmut K. C. Tessarek) | Owned by: | tessus (Helmut K. C. Tessarek) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.4.1 |
| Keywords: | haspatch maintainer | Cc: | raimue (Rainer Müller) |
| Port: | ansifilter |
Description
Pull request will be on gh.
This is really confusing. I can't reference a pull request, because I only can create a pull request, when I've created the ticket, so that the ticket is referenced in the commit.
Can someone please explain the correct process? The documentation is not very clear about that.
Change History (9)
comment:1 Changed 7 years ago by l2dy (Zero King)
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
comment:2 Changed 7 years ago by tessus (Helmut K. C. Tessarek)
Thanks, but that's exactly where the confusion started. The documentation states: open a ticket. The template states AFTER the verification item to reference the ticket, not to open a ticket.
So here are 3 problems:
- Chicken an egg problem. What am I supposed to read first? Documentation or the pull request template?
- The logical flow in the template.md file is kind of broken. Usually a conditional is set before the action.
- The statement at the beginning delete not applicable items is a problem. This means I could delete all of them, because I didn't do any of them.
comment:3 Changed 7 years ago by tessus (Helmut K. C. Tessarek)
How long does it take for the pull requests to be merged? When I opened a ticket with a patch attached (and the haspatch and maintainer keywords), it ususally never took longer than a day. Now my 2 PR have been open for 3 days.
comment:4 Changed 7 years ago by tessus (Helmut K. C. Tessarek)
Sorry, I've just noticed that the previous comment might sound harsh, but it was an honest question and not meant to be harsh.
comment:5 Changed 7 years ago by raimue (Rainer Müller)
| Cc: | raimue added |
|---|
What specific "documentation" do you refer to? Where did you read that you need to open a ticket? To get it fixed we will need to know where you read about this.
comment:6 Changed 7 years ago by tessus (Helmut K. C. Tessarek)
The Contributions section, first sentence. https://guide.macports.org/#project.contributing
Maybe you could add a sentence like: You can also send us a pull request on github (link to gh PR) in which case no ticket needs to be opened.
But it also states: You can, however, apply for commit access once you have some experience in maintaining ports. In fact, we would like to encourage you to apply after a few months.
It has been a few months. I'd like to apply for commit access. For ports tmux and ansifilter. Yes, I know, commit access is for everything. It's easy to revert a commit and you can ban me forever should I ever misuse the commit access.
comment:7 Changed 7 years ago by tessus (Helmut K. C. Tessarek)
Additional info: https://guide.macports.org/#project.contributing.updates
Item 3: Create a Trac ticket. Maybe you could also add the following text or open a pull request.
comment:8 Changed 7 years ago by tessus (Helmut K. C. Tessarek)
can you please have a look at https://github.com/macports/macports-ports/pull/419 and https://github.com/macports/macports-ports/pull/421
These are truly minor and simple updates.
comment:9 Changed 7 years ago by tessus (Helmut K. C. Tessarek)
| Owner: | set to tessus |
|---|---|
| Resolution: | duplicate → fixed |
Please don't open a new Trac ticket if you are submitting a pull request.
P.S. This is documented in PULL_REQUEST_TEMPLATE.md.